chore: Reduce memory consumption of AMVF #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR
Main
|
paulgessinger
commented
Dec 14, 2023
📊: Physics performance monitoring for 01533e8physmon summary
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2832 +/- ##
==========================================
+ Coverage 48.82% 48.85% +0.02%
==========================================
Files 484 486 +2
Lines 28136 28178 +42
Branches 13278 13292 +14
==========================================
+ Hits 13738 13766 +28
- Misses 4792 4796 +4
- Partials 9606 9616 +10 ☔ View full report in Codecov by Sentry. |
|
Runtime of the ckf tracking physmon workflow seems unaffected (100 events, 30 runs each, no IO, single thread). Main
This PR
|
andiwand
approved these changes
Dec 15, 2023
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
This pushes a number of vertex calculations to separate `.cpp` files so they can be compiled once and linked. This switches a couple of dimension checks to runtime checks. I didn't do a runtime test yet, but that's something I need to check. The memory consumption goes down by around 30%, while adding two new compilation units of about 900M each.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pushes a number of vertex calculations to separate
.cppfiles so they can be compiled once and linked. This switches a couple of dimension checks to runtime checks. I didn't do a runtime test yet, but that's something I need to check.The memory consumption goes down by around 30%, while adding two new compilation units of about 900M each.