feat: Add common hough transform components to core #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2836 +/- ##
==========================================
+ Coverage 48.98% 48.99% +0.01%
==========================================
Files 494 492 -2
Lines 28742 28527 -215
Branches 13606 13485 -121
==========================================
- Hits 14078 13978 -100
+ Misses 4854 4814 -40
+ Partials 9810 9735 -75 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 8501e7bphysmon summary
|
|
Dear @paulgessinger, many thanks for the first look at this MR! One Q, do I need to do a manual squash & rebase, or will this be done later? |
|
This happens at the end, no need to do it manually! |
|
uuups, I think I did a merge fu ... |
github-actions
bot
added
the
Infrastructure
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
paulgessinger
approved these changes
Jan 23, 2024
acts-project-service
added
the
Fails Athena tests
|
Athena failure is unrelated to changes, ATLAS / CERN is having infrastructure issues. |
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
This PR refactors the logic originally put into ACTS by @jahreda for the example hough transform algorithm. Migrate suitable for common usage to core. Fix a few bugs in the process and improve execution efficiency. Add an additional example algorithm implementing an ATLAS muon spectrometer hough transform to test the new logic. --------- Co-authored-by: jahreda <57440432+jahreda@users.noreply.github.com> Co-authored-by: Riley Xu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the logic originally put into ACTS by @jahreda for the example hough transform algorithm.
Migrate suitable for common usage to core.
Fix a few bugs in the process and improve execution efficiency.
Add an additional example algorithm implementing an ATLAS muon spectrometer hough transform to test the new logic.
CC @junggjo9 @noemina @dimitra97