feat: adding features for traccc data production #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
|
Hey @niermann999 - this is the necessary code to retrieve / set the identifiers on the ACTS side to a Acts::Detector - it does not yet contain the geometry fixes which should come shortly after. |
📊: Physics performance monitoring for 558c037physmon summary
|
AJPfleger
reviewed
Dec 19, 2023
niermann999
reviewed
Dec 19, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2845 +/- ##
=======================================
Coverage 48.86% 48.87%
=======================================
Files 485 485
Lines 28175 28206 +31
Branches 13280 13288 +8
=======================================
+ Hits 13769 13786 +17
- Misses 4821 4829 +8
- Partials 9585 9591 +6 ☔ View full report in Codecov by Sentry. |
niermann999
previously approved these changes
Dec 19, 2023
acts-policybot
bot
dismissed
niermann999’s stale review
Invalidated by push of 26be85e
|
@niermann999 - I had a python formatting issue, please re-approve. |
niermann999
previously approved these changes
Dec 19, 2023
acts-policybot
bot
dismissed
niermann999’s stale review
Invalidated by push of 087f5bf
|
Hey @niermann999 - had python formatting problem and a clang-tidy complaint, so please a hopefully final re-approval |
AJPfleger
approved these changes
Dec 20, 2023
acts-project-service
added
the
Breaks Athena build
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
This PR adds some necessary fixes for producing traccc data, particularly the possibility to set and assign custom GeometryID values to the new `Acts::Detector`. It also contains a missing fix for unit conversion DD4hep/ACTS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some necessary fixes for producing traccc data, particularly the possibility to set and assign custom GeometryID values to the new
Acts::Detector.It also contains a missing fix for unit conversion DD4hep/ACTS.