-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: name change of FTF -> GBTS seeding #2853
Conversation
Updating branch from main
Updating from main
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2853 +/- ##
=======================================
Coverage 48.83% 48.83%
=======================================
Files 486 486
Lines 28175 28175
Branches 13285 13285
=======================================
Hits 13760 13760
Misses 4820 4820
Partials 9595 9595 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 1e72a53physmon summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks already quite fine. I think, there are only(?) 3 things to change:
- Start variable names with lower case
- Drop most of the underscores except for
m_afterThatNoUnderScores
and maybe in the python scripts - Change
*ipp
to.*cpp
when you are already renaming files. But this is argueable.
Examples/Algorithms/TrackFinding/include/ActsExamples/TrackFinding/GbtsSeedingAlgorithm.hpp
Outdated
Show resolved
Hide resolved
@AJPfleger Thank you for your help, I am making the name changes for the variables. For the ipp -> cpp I just wanted to double check as all the other files in core seeding are ipp/hpp |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think after these changes we are ready to go.
There are still a few other variables that need to be renamed, but they are not really in the scope of this PR. Since you planned to refactor/modernise the code code, some of them might even vanish. So no need to put too much thinking into it right now.
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Change naming of new seeding algorithm from FTF (FastTrackFinder) to GBTS (Graph Based Track Seeding) as this is a clearer desription of the algorithm. Name changes disccuessed in issue acts-project#2831 . Code implemented in PRs acts-project#2227 acts-project#2726 and more details given presented at [ACTS-ITK presention ](https://indico.cern.ch/event/1321208/#20-update-on-ftf-implementatio). **Name changes**: SeedFinderFTF -> SeedFinderGBTS GNN_DataStorage -> GBTSDataStorage GNN_Geometry -> GBTSGeometry SeedingFTFAlgorithm -> GBTSSeedingAlgorithm FasTrackConnector-> GBTSConnector TrigBase -> GBTSBase full_chain_itk_FTF.py -> full_chain_itk_GBTS.py
Change naming of new seeding algorithm from FTF (FastTrackFinder) to GBTS (Graph Based Track Seeding) as this is a clearer desription of the algorithm. Name changes disccuessed in issue #2831 .
Code implemented in PRs #2227 #2726 and more details given presented at ACTS-ITK presention .
Name changes:
SeedFinderFTF -> SeedFinderGBTS
GNN_DataStorage -> GBTSDataStorage
GNN_Geometry -> GBTSGeometry
SeedingFTFAlgorithm -> GBTSSeedingAlgorithm
FasTrackConnector-> GBTSConnector
TrigBase -> GBTSBase
full_chain_itk_FTF.py -> full_chain_itk_GBTS.py