refactor!: Untemplate Vertex

[paulgessinger]

This PR makes Vertex a concrete type, which is possible after moving input track to be a concrete type erased type.

Part of:

• refactor: Vertex implementation #2842

Blocked by:

• refactor!: Vertex InputTrack becomes concrete type #2876

[github-actions]

📊: Physics performance monitoring for f6295d4

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles fatras
• ✅ Particles geant4

[codecov]

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (9b2fd7d) 48.94% compared to head (428592a) 48.99%.
Report is 2 commits behind head on main.

❗ Current head 428592a differs from pull request most recent head f6295d4. Consider uploading reports for the commit f6295d4 to get more accurate results

Files	Patch %	Lines
...e/include/Acts/Vertexing/IterativeVertexFinder.ipp	36.84%	3 Missing and 9 partials ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp	47.61%	1 Missing and 10 partials ⚠️
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp	33.33%	2 Missing and 6 partials ⚠️
...include/Acts/Vertexing/FullBilloirVertexFitter.ipp	41.66%	0 Missing and 7 partials ⚠️
Core/include/Acts/Vertexing/TrackAtVertex.hpp	68.75%	4 Missing and 1 partial ⚠️
...Acts/Vertexing/AdaptiveGridDensityVertexFinder.ipp	0.00%	1 Missing and 3 partials ⚠️
...include/Acts/Vertexing/GridDensityVertexFinder.ipp	0.00%	0 Missing and 4 partials ⚠️
...nclude/Acts/Vertexing/TrackDensityVertexFinder.ipp	0.00%	0 Missing and 2 partials ⚠️
Core/include/Acts/Vertexing/Vertex.ipp	90.90%	0 Missing and 2 partials ⚠️
Core/include/Acts/Vertexing/ZScanVertexFinder.ipp	33.33%	0 Missing and 2 partials ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2877      +/-   ##
==========================================
+ Coverage   48.94%   48.99%   +0.05%     
==========================================
  Files         496      496              
  Lines       28913    28938      +25     
  Branches    13710    13704       -6     
==========================================
+ Hits        14151    14179      +28     
- Misses       4878     4881       +3     
+ Partials     9884     9878       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[paulgessinger]

This is ready to review now @andiwand.

[andiwand]

that's a blessing 🙏

Invalidated by push of 035a5b4

[paulgessinger]

This is ready now @andiwand

[acts-project-service]

🔴 Athena integration test results [dfd4356]

Build job with this PR failed!

Please investigate the build job for the pipeline!