Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Remove input_track_t template parameters #2880

Merged

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Jan 18, 2024

This PR should completely remove the use of input_track_t.

Part of:

Blocked by:

@paulgessinger paulgessinger added this to the v32.0.0 milestone Jan 18, 2024
@paulgessinger paulgessinger marked this pull request as draft January 18, 2024 17:17
@paulgessinger paulgessinger force-pushed the refactor/vtx-templates-part3 branch from a698272 to feab61e Compare January 18, 2024 17:37
@github-actions github-actions bot added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module Vertexing labels Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4e25aa2) 48.96% compared to head (7eac5ca) 48.90%.

Files Patch % Lines
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp 75.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2880      +/-   ##
==========================================
- Coverage   48.96%   48.90%   -0.07%     
==========================================
  Files         495      495              
  Lines       28918    28889      -29     
  Branches    13702    13707       +5     
==========================================
- Hits        14161    14128      -33     
  Misses       4881     4881              
- Partials     9876     9880       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger paulgessinger modified the milestones: v32.0.0, v33.0.0 Jan 19, 2024
@andiwand andiwand added the 🛑 blocked This item is blocked by another item label Jan 22, 2024
@paulgessinger paulgessinger force-pushed the refactor/vtx-templates-part3 branch from feab61e to 45b52fd Compare January 22, 2024 08:26
@github-actions github-actions bot removed the Infrastructure Changes to build tools, continous integration, ... label Jan 22, 2024
@paulgessinger paulgessinger force-pushed the refactor/vtx-templates-part3 branch 2 times, most recently from 8004b30 to 238351b Compare January 24, 2024 12:04
@paulgessinger paulgessinger force-pushed the refactor/vtx-templates-part3 branch 5 times, most recently from 206415a to ae96bde Compare February 6, 2024 13:01
@paulgessinger paulgessinger force-pushed the refactor/vtx-templates-part3 branch from ae96bde to aecff94 Compare February 7, 2024 16:18
@paulgessinger paulgessinger marked this pull request as ready for review February 7, 2024 16:18
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Feb 7, 2024
@paulgessinger
Copy link
Member Author

@andiwand this is ready now.

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary complexity = gone

@kodiakhq kodiakhq bot merged commit 89858d9 into acts-project:main Feb 8, 2024
52 checks passed
@github-actions github-actions bot removed the automerge label Feb 8, 2024
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [89858d9]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Feb 8, 2024
@paulgessinger paulgessinger deleted the refactor/vtx-templates-part3 branch February 8, 2024 11:06
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
)

This PR should completely remove the use of `input_track_t`.

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2878
kodiakhq bot pushed a commit that referenced this pull request Feb 13, 2024
This PR switches away from using `std::function` for the parameter extraction to `Delegate`.

Part of:
- #2842 

Blocked by: 
- #2880
@paulgessinger paulgessinger added Breaks Athena build This PR breaks the Athena build and removed Breaks Athena build This PR breaks the Athena build labels Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
)

This PR should completely remove the use of `input_track_t`.

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2878
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
This PR switches away from using `std::function` for the parameter extraction to `Delegate`.

Part of:
- acts-project#2842 

Blocked by: 
- acts-project#2880
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
)

This PR should completely remove the use of `input_track_t`.

Part of:
- acts-project#2842 

Blocked by:
- acts-project#2878
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
This PR switches away from using `std::function` for the parameter extraction to `Delegate`.

Part of:
- acts-project#2842 

Blocked by: 
- acts-project#2880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Examples Affects the Examples module Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants