Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Safety checks for CylindricalContainerBuilder BluePrint constructor #2883

Conversation

ssdetlab
Copy link
Contributor

Adding empty builders container and specific binning types safety checks to the BluePrint constructor of the CyllindricalContainerBuilder.

@github-actions github-actions bot added the Component - Core Affects the Core module label Jan 18, 2024
@ssdetlab
Copy link
Contributor Author

Moved RootVolumeFinderBuilder to the end of construct to prevent exiting the function before the GeometryId and Portal Material are assigned

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (a8c79de) 0.00% compared to head (bf16fc7) 48.92%.

Files Patch % Lines
Core/src/Detector/CylindricalContainerBuilder.cpp 11.11% 12 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2883       +/-   ##
=========================================
+ Coverage      0   48.92%   +48.92%     
=========================================
  Files         0      494      +494     
  Lines         0    28661    +28661     
  Branches      0    13558    +13558     
=========================================
+ Hits          0    14021    +14021     
- Misses        0     4883     +4883     
- Partials      0     9757     +9757     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asalzburger asalzburger added this to the next milestone Jan 19, 2024
@kodiakhq kodiakhq bot merged commit 390dd30 into acts-project:main Jan 19, 2024
54 checks passed
@acts-project-service
Copy link
Collaborator

✅ Athena integration test results [390dd30]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateResolvedTracks.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsGSFRefitting.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@paulgessinger paulgessinger modified the milestones: next, v32.1.0 Feb 2, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
…ctor (acts-project#2883)

Adding empty builders container and specific binning types safety checks to the BluePrint constructor of the CyllindricalContainerBuilder.
@ssdetlab ssdetlab deleted the cylindrical-container-builder-blueprint-safety-checks branch October 11, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants