-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Safety checks for CylindricalContainerBuilder BluePrint constructor #2883
Merged
kodiakhq
merged 5 commits into
acts-project:main
from
ssdetlab:cylindrical-container-builder-blueprint-safety-checks
Jan 19, 2024
Merged
feat: Safety checks for CylindricalContainerBuilder BluePrint constructor #2883
kodiakhq
merged 5 commits into
acts-project:main
from
ssdetlab:cylindrical-container-builder-blueprint-safety-checks
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved RootVolumeFinderBuilder to the end of construct to prevent exiting the function before the GeometryId and Portal Material are assigned |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2883 +/- ##
=========================================
+ Coverage 0 48.92% +48.92%
=========================================
Files 0 494 +494
Lines 0 28661 +28661
Branches 0 13558 +13558
=========================================
+ Hits 0 14021 +14021
- Misses 0 4883 +4883
- Partials 0 9757 +9757 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for bf16fc7physmon summary
|
asalzburger
approved these changes
Jan 19, 2024
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
…ctor (acts-project#2883) Adding empty builders container and specific binning types safety checks to the BluePrint constructor of the CyllindricalContainerBuilder.
ssdetlab
deleted the
cylindrical-container-builder-blueprint-safety-checks
branch
October 11, 2024 12:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding empty builders container and specific binning types safety checks to the BluePrint constructor of the CyllindricalContainerBuilder.