Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create SVG python bindings for new detector #2884

Merged
merged 12 commits into from
Jan 23, 2024

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Jan 19, 2024

This PR introduces python bindings for the new detector and gives convenience functions to select volumes, restrict views and color them eventually.

An example is show cased in detector_creation which would need thirdparty/OpenDataDetector with version v3.0.3.

This would produce things like this:

Screenshot 2024-01-19 at 16 45 40

Screenshot 2024-01-19 at 16 45 56

@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module labels Jan 19, 2024
@asalzburger asalzburger added this to the next milestone Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (1152851) 48.97% compared to head (c00457a) 48.98%.

Files Patch % Lines
Core/src/Geometry/Extent.cpp 37.50% 2 Missing and 8 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2884   +/-   ##
=======================================
  Coverage   48.97%   48.98%           
=======================================
  Files         494      494           
  Lines       28734    28742    +8     
  Branches    13600    13606    +6     
=======================================
+ Hits        14073    14078    +5     
+ Misses       4856     4854    -2     
- Partials     9805     9810    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@niermann999 niermann999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general

Core/src/Geometry/Extent.cpp Outdated Show resolved Hide resolved
Examples/Python/src/Geometry.cpp Show resolved Hide resolved
Examples/Python/src/Svg.cpp Outdated Show resolved Hide resolved
Examples/Python/src/Svg.cpp Outdated Show resolved Hide resolved
Examples/Python/src/Svg.cpp Outdated Show resolved Hide resolved
Examples/Python/src/Svg.cpp Outdated Show resolved Hide resolved
Examples/Scripts/Python/detector_creation.py Outdated Show resolved Hide resolved
@asalzburger asalzburger changed the title feat: create python bindings for new detector feat: create SVG python bindings for new detector Jan 20, 2024
@asalzburger asalzburger force-pushed the feat-add-svg-python--detector branch from 2cded5a to 66b42f4 Compare January 22, 2024 10:44
@asalzburger asalzburger force-pushed the feat-add-svg-python--detector branch from f88fb76 to 9bc6e7a Compare January 22, 2024 12:28
@asalzburger
Copy link
Contributor Author

@niermann999 - PR comments should be addressed now.

@kodiakhq kodiakhq bot merged commit 21d6c53 into acts-project:main Jan 23, 2024
54 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Jan 23, 2024

✅ Athena integration test results [21d6c53]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsEFTrackFit.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateResolvedTracks.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsGSFRefitting.sh
🟢 run_ci_tests: ../athena/Tracking/Acts/ActsConfig/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jan 23, 2024
@paulgessinger paulgessinger modified the milestones: next, v32.1.0 Feb 2, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
This PR introduces python bindings for the new detector and gives convenience functions to select volumes, restrict views and color them eventually.

An example is show cased in `detector_creation` which would need `thirdparty/OpenDataDetector` with version `v3.0.3`.

This would produce things like this:

![Screenshot 2024-01-19 at 16 45 40](https://github.com/acts-project/acts/assets/26623879/ccad9896-a7af-4478-bff1-5c7ac3cd43e6)

![Screenshot 2024-01-19 at 16 45 56](https://github.com/acts-project/acts/assets/26623879/86943e84-70c2-4ee0-9ab3-46813cda7cc9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants