-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create SVG python bindings for new detector #2884
feat: create SVG python bindings for new detector #2884
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2884 +/- ##
=======================================
Coverage 48.97% 48.98%
=======================================
Files 494 494
Lines 28734 28742 +8
Branches 13600 13606 +6
=======================================
+ Hits 14073 14078 +5
+ Misses 4856 4854 -2
- Partials 9805 9810 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general
2cded5a
to
66b42f4
Compare
f88fb76
to
9bc6e7a
Compare
@niermann999 - PR comments should be addressed now. |
📊: Physics performance monitoring for c00457aphysmon summary
|
This PR introduces python bindings for the new detector and gives convenience functions to select volumes, restrict views and color them eventually. An example is show cased in `detector_creation` which would need `thirdparty/OpenDataDetector` with version `v3.0.3`. This would produce things like this: ![Screenshot 2024-01-19 at 16 45 40](https://github.com/acts-project/acts/assets/26623879/ccad9896-a7af-4478-bff1-5c7ac3cd43e6) ![Screenshot 2024-01-19 at 16 45 56](https://github.com/acts-project/acts/assets/26623879/86943e84-70c2-4ee0-9ab3-46813cda7cc9)
This PR introduces python bindings for the new detector and gives convenience functions to select volumes, restrict views and color them eventually.
An example is show cased in
detector_creation
which would needthirdparty/OpenDataDetector
with versionv3.0.3
.This would produce things like this: