feat: add grid conversion option #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2894 +/- ##
==========================================
+ Coverage 48.90% 48.91% +0.01%
==========================================
Files 494 494
Lines 28822 28834 +12
Branches 13668 13671 +3
==========================================
+ Hits 14095 14104 +9
Misses 4874 4874
- Partials 9853 9856 +3 ☔ View full report in Codecov by Sentry. |
CarloVarni
requested changes
Jan 24, 2024
CarloVarni
previously approved these changes
Jan 25, 2024
|
Hi @CarloVarni - thanks for the review, I fixed a spelling mistake, so if you could re-approve, would be great, thanks. |
📊: Physics performance monitoring for de8caf4physmon summary
|
CarloVarni
approved these changes
Jan 25, 2024
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
This PR adds functionality to a grid to ease conversions between grid. Two methods are added: - `convertType<NewType>` creates a new empty grid with identical axes and new holder type - `convertGrid<Converter>` converts the grid into a new grid and perform conversion of the values UnitTests are added to check this functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to a grid to ease conversions between grid.
Two methods are added:
convertType<NewType>creates a new empty grid with identical axes and new holder typeconvertGrid<Converter>converts the grid into a new grid and perform conversion of the valuesUnitTests are added to check this functionality.