feat: adding visitSurfaces pattern to new detector #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJPfleger
requested changes
Jan 25, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2897 +/- ##
=======================================
Coverage 48.91% 48.92%
=======================================
Files 494 496 +2
Lines 28834 28849 +15
Branches 13671 13677 +6
=======================================
+ Hits 14104 14113 +9
Misses 4874 4874
- Partials 9856 9862 +6 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for f70eaa7physmon summary
|
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
AJPfleger
previously approved these changes
Jan 25, 2024
|
Hey @AJPfleger - I had a clang-tidy failure, which I fixed. Please re-approve. |
AJPfleger
approved these changes
Jan 25, 2024
|
Overriding CI infrastructure failure |
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
This PR adds the `visitSurfaces(...)` pattern to the new Detector analog to the pattern in the TrackingGeometry world. This is a next step to harmonise the two branches for an eventual transition to the new detector geometry. It adds consistent testing of this setups as well. --------- Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
visitSurfaces(...)pattern to the new Detector analog to the pattern in the TrackingGeometry world.This is a next step to harmonise the two branches for an eventual transition to the new detector geometry.
It adds consistent testing of this setups as well.