Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gx2f): Add new error DidNotConverge #2898

Merged
merged 10 commits into from
Jan 29, 2024
Merged

Conversation

AJPfleger
Copy link
Contributor

Returns an error, if the fitter does not converge within the maximum number of updates.

@AJPfleger AJPfleger added this to the next milestone Jan 26, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7d596d1) 48.92% compared to head (88a93bb) 48.92%.

Files Patch % Lines
...re/src/TrackFitting/GlobalChiSquareFitterError.cpp 0.00% 2 Missing ⚠️
...nclude/Acts/TrackFitting/GlobalChiSquareFitter.hpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2898   +/-   ##
=======================================
  Coverage   48.92%   48.92%           
=======================================
  Files         496      496           
  Lines       28849    28855    +6     
  Branches    13677    13680    +3     
=======================================
+ Hits        14113    14118    +5     
+ Misses       4874     4873    -1     
- Partials     9862     9864    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AJPfleger AJPfleger requested a review from andiwand January 29, 2024 12:38
@kodiakhq kodiakhq bot merged commit 6aeeeda into acts-project:main Jan 29, 2024
52 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jan 29, 2024
@paulgessinger paulgessinger modified the milestones: next, v32.1.0 Feb 2, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
Returns an error, if the fitter does not converge within the maximum number of updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants