feat: adapt visitor concept #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
==========================================
+ Coverage 48.92% 48.93% +0.01%
==========================================
Files 496 496
Lines 28849 28899 +50
Branches 13677 13705 +28
==========================================
+ Hits 14113 14142 +29
+ Misses 4874 4872 -2
- Partials 9862 9885 +23 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for ab6dd0dphysmon summary
|
|
If this is breaking we need to hold this until v33. |
|
I'm happy with this, but we'll really have to hold this until the next major version I think. |
|
Hey @paulgessinger - I have done as you suggested, it should now not be breaking change anymore. |
paulgessinger
approved these changes
Jan 29, 2024
🔴 Athena integration test results [5166de1]🔴 Some tests have failed!Please investigate the pipeline! |
acts-project-service
added
the
Fails Athena tests
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
This PR enhances the visitor pattern for the Acts geometry. It adds a non-const visitor pattern which will allow to also use the visitor pattern to set the material to the new detector geometry and will replace this `IMaterialProvider` mechanism and will rely on the same recursive visiting. The unit tests show how this can be used to assign material to a pre-built geometry instance. Note: The new `visitSurfaces` method of the `TrackingGeometry` will now visit all reachable surfaces, and not only the sensitive ones. This allows it to e.g. extract material surfaces and will remove a lot of duplicated code in `SurfaceMaterialMapper` and `VolumeMaterialMapper` that manually walk through the `TrackingGeometry` hierarchy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the visitor pattern for the Acts geometry.
It adds a non-const visitor pattern which will allow to also use the visitor pattern to set the material to the new detector geometry and will replace this
IMaterialProvidermechanism and will rely on the same recursive visiting.The unit tests show how this can be used to assign material to a pre-built geometry instance.
Note: The new
visitSurfacesmethod of theTrackingGeometrywill now visit all reachable surfaces, and not only the sensitive ones. This allows it to e.g. extract material surfaces and will remove a lot of duplicated code inSurfaceMaterialMapperandVolumeMaterialMapperthat manually walk through theTrackingGeometryhierarchy.