Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Use common direction transform Jacobian (#2782) #2907

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

andiwand
Copy link
Contributor

Output changes are not tolerated by Athena and will be patched to v32.

@github-actions github-actions bot added the Component - Core Affects the Core module label Jan 29, 2024
@andiwand
Copy link
Contributor Author

This should not target main but a release branch which does not exist yet.

Waiting for the CI to complete to update the references

@AJPfleger AJPfleger self-requested a review January 29, 2024 12:17
@paulgessinger paulgessinger changed the base branch from main to develop/v32.0.x January 29, 2024 12:26
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (b6480f7) 49.03% compared to head (2a6099d) 49.11%.

❗ Current head 2a6099d differs from pull request most recent head 372f0c7. Consider uploading reports for the commit 372f0c7 to get more accurate results

Files Patch % Lines
Core/src/Surfaces/DiscSurface.cpp 6.89% 15 Missing and 12 partials ⚠️
Core/src/Surfaces/Surface.cpp 14.28% 0 Missing and 12 partials ⚠️
Core/src/Surfaces/LineSurface.cpp 0.00% 0 Missing and 9 partials ⚠️
Core/src/Propagator/detail/JacobianEngine.cpp 97.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           develop/v32.0.x    #2907      +/-   ##
===================================================
+ Coverage            49.03%   49.11%   +0.08%     
===================================================
  Files                  492      491       -1     
  Lines                28542    28570      +28     
  Branches             13487    13475      -12     
===================================================
+ Hits                 13995    14032      +37     
- Misses                4819     4828       +9     
+ Partials              9728     9710      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger paulgessinger added this to the v32.0.1 milestone Jan 29, 2024
@paulgessinger
Copy link
Member

Hashes still need to be updated, I believe.

@paulgessinger paulgessinger merged commit daeea07 into acts-project:develop/v32.0.x Jan 30, 2024
48 of 50 checks passed
@andiwand andiwand deleted the revert-2782 branch January 30, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants