Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update ParticleDataTable.hpp #2908

Merged
merged 16 commits into from
Apr 11, 2024

Conversation

paulgessinger
Copy link
Member

This updates the script to generate our particle data table from scikithep, and updates the table.

This updates the script to generate our particle data table from
scikithep, and updates the table.
@paulgessinger paulgessinger added this to the next milestone Jan 29, 2024
@paulgessinger
Copy link
Member Author

This also adds many many more PDG IDs, as scikithep particle was updated to include them. I'm wondering if at this point we should switch to using a std::map / binary search for these lookups.

@github-actions github-actions bot added Component - Core Affects the Core module Component - Fatras Affects the Fatras module labels Jan 29, 2024
@AJPfleger
Copy link
Contributor

Does clang-format do anything after generating the data base?
Maybe we should remove it? Since we don't expect any changes, an ill setup system could even mal-format the file.

@paulgessinger
Copy link
Member Author

paulgessinger commented Jan 29, 2024

This is not intended to be run very often, so I would say it's not super critical. I think it just makes sure the formatting is fine, because the generation script does not ensure this at all.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.06%. Comparing base (3203649) to head (7050a1e).
Report is 7 commits behind head on main.

❗ Current head 7050a1e differs from pull request most recent head 52f0869. Consider uploading reports for the commit 52f0869 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2908      +/-   ##
==========================================
- Coverage   49.09%   49.06%   -0.04%     
==========================================
  Files         497      495       -2     
  Lines       29155    28978     -177     
  Branches    13851    13740     -111     
==========================================
- Hits        14314    14218      -96     
- Misses       4908     4928      +20     
+ Partials     9933     9832     -101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger
Copy link
Member Author

Memory consumption of compiling this header file goes from 60M to 77M, which I think we can tolerate.

andiwand
andiwand previously approved these changes Jan 30, 2024
@andiwand
Copy link
Contributor

andiwand commented Mar 1, 2024

Are the output changes coming from changes in particle properties like mass @paulgessinger ? Let's look at the new plots and check how big the variation is

@paulgessinger
Copy link
Member Author

I haven't looked into this further. I'd wouldn't have expected masses to change actually but who knows.

@andiwand
Copy link
Contributor

andiwand commented Mar 1, 2024

physmon looks like outliers moved a bit - unproblematic from my side

@github-actions github-actions bot added the Stale label Mar 31, 2024
@github-actions github-actions bot removed the Stale label Apr 2, 2024
@AJPfleger
Copy link
Contributor

@andiwand suggested in the dev-meeting:

  • physmon is fine again, maybe just clash with different PR
  • 1 hash changed, maybe because one of the masses changed. We should go with the updated mass.

Next step: @andiwand will update the hash

AJPfleger
AJPfleger previously approved these changes Apr 10, 2024
@andiwand andiwand requested a review from AJPfleger April 10, 2024 13:32
AJPfleger
AJPfleger previously approved these changes Apr 10, 2024
Copy link
Contributor

kodiakhq bot commented Apr 11, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge label Apr 11, 2024
AJPfleger
AJPfleger previously approved these changes Apr 11, 2024
@kodiakhq kodiakhq bot merged commit 539f2c9 into acts-project:main Apr 11, 2024
51 checks passed
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
This updates the script to generate our particle data table from scikithep, and updates the table.


Co-authored-by: Andreas Stefl <487211+andiwand@users.noreply.github.com>
@andiwand andiwand modified the milestones: next, v34.0.0 Apr 25, 2024
kodiakhq bot pushed a commit that referenced this pull request Apr 29, 2024
It's not possible to make these compile time constants if we want to share the constants with `ParticleData` but we can make them runtime constants.

It looks like the `findMass` / `findCharge` calls got more expensive after #2908 but I don't see a reason to optimize them after keeping caching the hypothesis.
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
This updates the script to generate our particle data table from scikithep, and updates the table.


Co-authored-by: Andreas Stefl <487211+andiwand@users.noreply.github.com>
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
It's not possible to make these compile time constants if we want to share the constants with `ParticleData` but we can make them runtime constants.

It looks like the `findMass` / `findCharge` calls got more expensive after acts-project#2908 but I don't see a reason to optimize them after keeping caching the hypothesis.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
This updates the script to generate our particle data table from scikithep, and updates the table.


Co-authored-by: Andreas Stefl <487211+andiwand@users.noreply.github.com>
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
It's not possible to make these compile time constants if we want to share the constants with `ParticleData` but we can make them runtime constants.

It looks like the `findMass` / `findCharge` calls got more expensive after acts-project#2908 but I don't see a reason to optimize them after keeping caching the hypothesis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants