-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update ParticleDataTable.hpp #2908
chore: Update ParticleDataTable.hpp #2908
Conversation
This updates the script to generate our particle data table from scikithep, and updates the table.
This also adds many many more PDG IDs, as scikithep particle was updated to include them. I'm wondering if at this point we should switch to using a |
Does |
This is not intended to be run very often, so I would say it's not super critical. I think it just makes sure the formatting is fine, because the generation script does not ensure this at all. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2908 +/- ##
==========================================
- Coverage 49.09% 49.06% -0.04%
==========================================
Files 497 495 -2
Lines 29155 28978 -177
Branches 13851 13740 -111
==========================================
- Hits 14314 14218 -96
- Misses 4908 4928 +20
+ Partials 9933 9832 -101 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 52f0869physmon summary
|
Memory consumption of compiling this header file goes from 60M to 77M, which I think we can tolerate. |
Are the output changes coming from changes in particle properties like mass @paulgessinger ? Let's look at the new plots and check how big the variation is |
I haven't looked into this further. I'd wouldn't have expected masses to change actually but who knows. |
physmon looks like outliers moved a bit - unproblematic from my side |
This PR currently has a merge conflict. Please resolve this and then re-add the |
This updates the script to generate our particle data table from scikithep, and updates the table. Co-authored-by: Andreas Stefl <487211+andiwand@users.noreply.github.com>
It's not possible to make these compile time constants if we want to share the constants with `ParticleData` but we can make them runtime constants. It looks like the `findMass` / `findCharge` calls got more expensive after #2908 but I don't see a reason to optimize them after keeping caching the hypothesis.
This updates the script to generate our particle data table from scikithep, and updates the table. Co-authored-by: Andreas Stefl <487211+andiwand@users.noreply.github.com>
It's not possible to make these compile time constants if we want to share the constants with `ParticleData` but we can make them runtime constants. It looks like the `findMass` / `findCharge` calls got more expensive after acts-project#2908 but I don't see a reason to optimize them after keeping caching the hypothesis.
This updates the script to generate our particle data table from scikithep, and updates the table. Co-authored-by: Andreas Stefl <487211+andiwand@users.noreply.github.com>
It's not possible to make these compile time constants if we want to share the constants with `ParticleData` but we can make them runtime constants. It looks like the `findMass` / `findCharge` calls got more expensive after acts-project#2908 but I don't see a reason to optimize them after keeping caching the hypothesis.
This updates the script to generate our particle data table from scikithep, and updates the table.