Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DirectNavigator causes incorrect propagation finalization #2913

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix: DirectNavigator causes incorrect propagation finalization #2913

merged 2 commits into from
Jan 31, 2024

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Jan 30, 2024 •
edited
Loading

This is observed to break the KalmanFitter if run with the direct navigator, at least in some cases. To be followed up with a more robust solution.

@paulgessinger
fix: DirectNavigator causes incorrect propagation finalization
85c4d62 
This is observed to break the KalmanFitter if run with the direct
navigator, at least in some cases. To be followed
@paulgessinger paulgessinger added this to the v32.0.2 milestone Jan 30, 2024
@paulgessinger paulgessinger changed the title revert: Use common direction transform Jacobian (originally #2782) (#… fix: DirectNavigator causes incorrect propagation finalization Jan 30, 2024
andiwand
andiwand approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thank you!

@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop/v32.0.x@daeea07). Click here to learn what that means.

❗ Current head 85c4d62 differs from pull request most recent head 4d6938c. Consider uploading reports for the commit 4d6938c to get more accurate results

Additional details and impacted files 
@@                Coverage Diff                 @@
##             develop/v32.0.x    #2913   +/-   ##
==================================================
  Coverage                   ?   49.11%           
==================================================
  Files                      ?      491           
  Lines                      ?    28574           
  Branches                   ?    13477           
==================================================
  Hits                       ?    14034           
  Misses                     ?     4828           
  Partials                   ?     9712

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

📊: Physics performance monitoring for 4d6938c

Full contents

physmon summary

@paulgessinger paulgessinger merged commit 318b50d into acts-project:develop/v32.0.x Jan 31, 2024
31 of 47 checks passed
@paulgessinger paulgessinger deleted the fix/kf-direct-navigator branch January 31, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v32.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@paulgessinger @andiwand