Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Closest forward intersection #2923

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Feb 1, 2024

Implements closest forward order and renames forwardOrder to pathLengthOrder

@andiwand andiwand added this to the next milestone Feb 1, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Fatras Affects the Fatras module labels Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9b2fd7d) 48.94% compared to head (0b56e92) 48.94%.
Report is 3 commits behind head on main.

❗ Current head 0b56e92 differs from pull request most recent head fae7580. Consider uploading reports for the commit fae7580 to get more accurate results

Files Patch % Lines
Core/src/Geometry/GenericApproachDescriptor.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2923   +/-   ##
=======================================
  Coverage   48.94%   48.94%           
=======================================
  Files         496      496           
  Lines       28913    28913           
  Branches    13710    13710           
=======================================
  Hits        14151    14151           
  Misses       4878     4878           
  Partials     9884     9884           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andiwand andiwand requested a review from asalzburger February 1, 2024 13:32
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, do you want @asalzburger to have a look too?

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this is really useful!

@kodiakhq kodiakhq bot merged commit ab41e0b into acts-project:main Feb 5, 2024
51 checks passed
@github-actions github-actions bot removed the automerge label Feb 5, 2024
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [ab41e0b]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Feb 5, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
Implements closest forward order and renames `forwardOrder` to `pathLengthOrder`
@andiwand andiwand deleted the feat-closest-forward-intersection branch March 1, 2024 15:33
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
@paulgessinger paulgessinger removed the Breaks Athena build This PR breaks the Athena build label Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
Implements closest forward order and renames `forwardOrder` to `pathLengthOrder`
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
Implements closest forward order and renames `forwardOrder` to `pathLengthOrder`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Fatras Affects the Fatras module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants