Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Write sumPt2 in VertexPerformanceWriter #2929

Merged
merged 8 commits into from
Feb 12, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Feb 5, 2024

This can be used to disambiguate multiple reco vertices assigned to the same truth vertex

@andiwand andiwand added this to the next milestone Feb 5, 2024
@andiwand andiwand requested a review from pbutti February 5, 2024 14:39
pbutti
pbutti previously approved these changes Feb 5, 2024
@pbutti
Copy link
Contributor

pbutti commented Feb 5, 2024

LGTM

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fa1300) 48.87% compared to head (ddc6771) 48.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2929   +/-   ##
=======================================
  Coverage   48.87%   48.87%           
=======================================
  Files         495      495           
  Lines       28904    28904           
  Branches    13722    13722           
=======================================
  Hits        14128    14128           
  Misses       4883     4883           
  Partials     9893     9893           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acts-policybot acts-policybot bot dismissed pbutti’s stale review February 7, 2024 10:41

Invalidated by push of 50d14d1

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Feb 7, 2024
@andiwand andiwand requested a review from pbutti February 8, 2024 20:44
@andiwand andiwand added automerge 🚧 WIP Work-in-progress and removed automerge 🚧 WIP Work-in-progress labels Feb 10, 2024
@paulgessinger paulgessinger merged commit 89450aa into acts-project:main Feb 12, 2024
59 of 60 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Feb 12, 2024
@andiwand andiwand deleted the feat-vertex-perf-sumpt2 branch February 12, 2024 17:49
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
This can be used to disambiguate multiple reco vertices assigned to the
same truth vertex

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
This can be used to disambiguate multiple reco vertices assigned to the
same truth vertex

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants