-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Write sumPt2
in VertexPerformanceWriter
#2929
Merged
paulgessinger
merged 8 commits into
acts-project:main
from
andiwand:feat-vertex-perf-sumpt2
Feb 12, 2024
Merged
feat: Write sumPt2
in VertexPerformanceWriter
#2929
paulgessinger
merged 8 commits into
acts-project:main
from
andiwand:feat-vertex-perf-sumpt2
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbutti
previously approved these changes
Feb 5, 2024
LGTM |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
=======================================
Coverage 48.87% 48.87%
=======================================
Files 495 495
Lines 28904 28904
Branches 13722 13722
=======================================
Hits 14128 14128
Misses 4883 4883
Partials 9893 9893 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for ddc6771physmon summary
|
acts-policybot
bot
dismissed
pbutti’s stale review
February 7, 2024 10:41
Invalidated by push of 50d14d1
github-actions
bot
added
Infrastructure
Changes to build tools, continous integration, ...
Changes Performance
labels
Feb 7, 2024
pbutti
approved these changes
Feb 9, 2024
🔴 Athena integration test results [89450aa]🔴 Some tests have failed!Please investigate the pipeline! |
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Feb 12, 2024
paulgessinger
removed
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Mar 6, 2024
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
This can be used to disambiguate multiple reco vertices assigned to the same truth vertex --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
This can be used to disambiguate multiple reco vertices assigned to the same truth vertex --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes Performance
Component - Examples
Affects the Examples module
Infrastructure
Changes to build tools, continous integration, ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to disambiguate multiple reco vertices assigned to the same truth vertex