Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix AMVF find single track vertices #2931

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Feb 5, 2024

The AMVF config addSingleTrackVertices was not correctly applied in the finding process and ended up always being true. This PR fixes the behavior.

discovered in #2917

@andiwand andiwand added this to the next milestone Feb 5, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Vertexing labels Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1df9175) 48.96% compared to head (3e860bd) 48.96%.

Files Patch % Lines
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2931   +/-   ##
=======================================
  Coverage   48.96%   48.96%           
=======================================
  Files         495      495           
  Lines       28919    28918    -1     
  Branches    13703    13702    -1     
=======================================
  Hits        14161    14161           
  Misses       4881     4881           
+ Partials     9877     9876    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit f0f0449 into acts-project:main Feb 7, 2024
52 checks passed
@github-actions github-actions bot removed the automerge label Feb 7, 2024
@andiwand andiwand deleted the fix-amvf-find-single-track-vertices branch February 7, 2024 15:06
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
The AMVF config `addSingleTrackVertices` was not correctly applied in the finding process and endet up always being `true`. This PR fixes the behavior.

discovered in acts-project#2917
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
The AMVF config `addSingleTrackVertices` was not correctly applied in the finding process and endet up always being `true`. This PR fixes the behavior.

discovered in acts-project#2917
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
The AMVF config `addSingleTrackVertices` was not correctly applied in the finding process and endet up always being `true`. This PR fixes the behavior.

discovered in acts-project#2917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants