-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix AMVF find single track vertices #2931
Merged
kodiakhq
merged 3 commits into
acts-project:main
from
andiwand:fix-amvf-find-single-track-vertices
Feb 7, 2024
Merged
fix: Fix AMVF find single track vertices #2931
kodiakhq
merged 3 commits into
acts-project:main
from
andiwand:fix-amvf-find-single-track-vertices
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊: Physics performance monitoring for 3e860bdphysmon summary
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2931 +/- ##
=======================================
Coverage 48.96% 48.96%
=======================================
Files 495 495
Lines 28919 28918 -1
Branches 13703 13702 -1
=======================================
Hits 14161 14161
Misses 4881 4881
+ Partials 9877 9876 -1 ☔ View full report in Codecov by Sentry. |
AJPfleger
approved these changes
Feb 7, 2024
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
The AMVF config `addSingleTrackVertices` was not correctly applied in the finding process and endet up always being `true`. This PR fixes the behavior. discovered in acts-project#2917
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
The AMVF config `addSingleTrackVertices` was not correctly applied in the finding process and endet up always being `true`. This PR fixes the behavior. discovered in acts-project#2917
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
The AMVF config `addSingleTrackVertices` was not correctly applied in the finding process and endet up always being `true`. This PR fixes the behavior. discovered in acts-project#2917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AMVF config
addSingleTrackVertices
was not correctly applied in the finding process and ended up always beingtrue
. This PR fixes the behavior.discovered in #2917