feat: full_chain_itk.py uses eta-dependent cuts

[timadye]

• addCKFTracks can now specify a trackSelectorConfig = list(TrackSelectorConfig) for eta-dependent cuts, with binning specified in absEta[1]. addCKFTracks() can be called with any of:
  1. trackSelectorConfig = (TrackSelectorConfig(), TrackSelectorConfig(), ...). See full_chain_itk.py for an example.
  2. trackSelectorConfig = TrackSelectorConfig(). Can also be specified as TrackSelectorConfig() as an non-kwarg. See full_chain_odd.py for an example.
  3. trackSelectorConfig = None (default)
• TrackSelectorConfig includes new cuts maxHoles, maxOutliers, maxSharedHits, and maxChi2.
• full_chain_itk.py now uses Athena's ITk track selections.

[timadye]

I can't get it to create a TrackSelector with EtaBinnedConfig, rather than the usual Config.

Traceback (most recent call last):
  File "/home/adye/acts/build-v32/python/acts/_adapter.py", line 32, in wrapped
    setattr(cfg, k, v)
TypeError: (): incompatible function arguments. The following argument types are supported:
    1. (self: acts.ActsPythonBindings._examples.TrackFindingAlgorithm.Config, arg0: Optional[acts.ActsPythonBindings.TrackSelector.Config]) -> None

Invoked with: <acts.ActsPythonBindings._examples.TrackFindingAlgorithm.Config object at 0x7f40249455f0>, <acts.ActsPythonBindings.TrackSelector.EtaBinnedConfig object at 0x7f40259be070>

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/adye/acts/run-v32/./src/Examples/Scripts/Python/full_chain_itk.py", line 109, in <module>
    addCKFTracks(
  File "/home/adye/acts/build-v32/python/acts/examples/__init__.py", line 185, in NamedTypeArgsWrapper
    return func(*newargs, **kwargs)
  File "/home/adye/acts/build-v32/python/acts/examples/reconstruction.py", line 1213, in addCKFTracks
    trackFinder = acts.examples.TrackFindingAlgorithm(
  File "/home/adye/acts/build-v32/python/acts/_adapter.py", line 34, in wrapped
    raise RuntimeError(
RuntimeError: <class 'acts.ActsPythonBindings._examples.TrackFindingAlgorithm.Config'>: Failed to set trackSelectorCfg=<acts.ActsPythonBindings.TrackSelector.EtaBinnedConfig object at 0x7f40259be070>

[github-actions]

📊: Physics performance monitoring for 2706e6e

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles fatras
• ✅ Particles geant4

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9da852) 48.96% compared to head (2706e6e) 48.96%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2934   +/-   ##
=======================================
  Coverage   48.96%   48.96%           
=======================================
  Files         495      495           
  Lines       28918    28918           
  Branches    13702    13702           
=======================================
  Hits        14161    14161           
  Misses       4881     4881           
  Partials     9876     9876           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[timadye]

I can't get it to create a TrackSelector with EtaBinnedConfig, rather than the usual Config.

This was because TrackFindingAlgorithm::Config only stored a Acts::TrackSelector::Config. The last commit changed it to a std::variant<Acts::TrackSelector::Config, Acts::TrackSelector::EtaBinnedConfig>, so either can be specified.

Now it works. addCKFTracks() can be called with any of:

1. trackSelectorConfig = (TrackSelectorConfig(), TrackSelectorConfig(), ...). See full_chain_itk.py for an example.
2. trackSelectorConfig = TrackSelectorConfig(). Can also be specified as TrackSelectorConfig() as an non-kwarg. See full_chain_odd.py for an example.
3. trackSelectorConfig = None (default)

[andiwand]

lgtm!

[acts-project-service]

✅ Athena integration test results [4e25aa2]

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	test_ActsEFTrackFit
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsConversionWorkflow
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco

[timadye]

Using the Athena ITk track selections now in full_chain_itk.py gives much better tracking efficiency for ttbar + PU200:

at the expense of some extra duplicates:

The job took ~25% longer, but I had some problems with the machine at the time, so it may have been unrelated.