feat: Add uber EDM4hep reader #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently only builds a particle tree with (hopefully) correct barcodes
also implements rudimentary graphviz output of "decay" chains.
This updates the script to generate our particle data table from scikithep, and updates the table.
This reverts commit 70bd5c8.
github-actions
bot
added
Component - Examples
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2939 +/- ##
==========================================
- Coverage 48.99% 48.78% -0.21%
==========================================
Files 495 493 -2
Lines 28937 28905 -32
Branches 13704 13747 +43
==========================================
- Hits 14178 14102 -76
- Misses 4881 4911 +30
- Partials 9878 9892 +14 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 35aa626physmon summary
|
andiwand
reviewed
Feb 8, 2024
Examples/Io/Performance/ActsExamples/Io/Performance/VertexPerformanceWriter.cpp
Outdated
Show resolved
Hide resolved
Examples/Io/EDM4hep/include/ActsExamples/Io/EDM4hep/EDM4hepReader.hpp
Outdated
Show resolved
Hide resolved
andiwand
previously approved these changes
Feb 20, 2024
|
I'd be inclined to ignore the coverage change in this case. |
|
no objection from my side since it is "only" examples does the coverage include the code covered by the python examples? |
|
It does not. I don't think it's doable to change that |
andiwand
approved these changes
Feb 27, 2024
acts-project-service
added
the
Breaks Athena build
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
This unifies the EDM4hep particle and simhit reader with correct particle barcodes, and working hit to particle association. I've tested to work ~ ok on ODD with ddsim inputs. ddsim produces weird hits that I haven't debugged yet, but given these inputs, the reco part seems to work somewhat ok. 
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
This unifies the EDM4hep particle and simhit reader with correct particle barcodes, and working hit to particle association. I've tested to work ~ ok on ODD with ddsim inputs. ddsim produces weird hits that I haven't debugged yet, but given these inputs, the reco part seems to work somewhat ok. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the EDM4hep particle and simhit reader with correct particle barcodes, and working hit to particle association. I've tested to work ~ ok on ODD with ddsim inputs. ddsim produces weird hits that I haven't debugged yet, but given these inputs, the reco part seems to work somewhat ok.