fix: TrackStateType printout in wrong order #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
|
This was found while investigating #2905 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2950 +/- ##
=======================================
Coverage 48.85% 48.85%
=======================================
Files 495 495
Lines 28897 28897
Branches 13726 13726
=======================================
Hits 14117 14117
Misses 4891 4891
Partials 9889 9889 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for e5ee50ephysmon summary
|
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
`operator<<(std::ostream& os, ConstTrackStateType t)` prints out the flag bits as a binary number, with bit 0 (`MeasurementFlag`) at the end. This is belied by the label `MPOHMS`, which should be `SMHOPM`. This PR fixes the label. Another option would be to reverse the order of bit printout. Please comment if you think that would be better.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
`operator<<(std::ostream& os, ConstTrackStateType t)` prints out the flag bits as a binary number, with bit 0 (`MeasurementFlag`) at the end. This is belied by the label `MPOHMS`, which should be `SMHOPM`. This PR fixes the label. Another option would be to reverse the order of bit printout. Please comment if you think that would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator<<(std::ostream& os, ConstTrackStateType t)prints out the flag bits as a binary number, with bit 0 (MeasurementFlag) at the end. This is belied by the labelMPOHMS, which should beSMHOPM.This PR fixes the label. Another option would be to reverse the order of bit printout. Please comment if you think that would be better.