refactor: Move large parts of Vertexing to .cpp files
#2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
paulgessinger
force-pushed
the
refactor/vtx-templates-part10-cpp-files
branch
from
4d08ceb to
80e812a
Compare
github-actions
bot
added
Component - Core
paulgessinger
force-pushed
the
refactor/vtx-templates-part10-cpp-files
branch
2 times, most recently
from
af35c8d to
774d1c5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2953 +/- ##
==========================================
- Coverage 48.78% 48.74% -0.05%
==========================================
Files 493 493
Lines 28905 28918 +13
Branches 13747 13760 +13
==========================================
- Hits 14102 14096 -6
- Misses 4911 4921 +10
- Partials 9892 9901 +9 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 51205fcphysmon summary
|
paulgessinger
force-pushed
the
refactor/vtx-templates-part10-cpp-files
branch
8 times, most recently
from
1616206 to
45f3dfa
Compare
andiwand
previously approved these changes
Feb 21, 2024
paulgessinger
force-pushed
the
refactor/vtx-templates-part10-cpp-files
branch
from
45f3dfa to
ecac772
Compare
|
I removed the trailing return types now @andiwand |
andiwand
previously approved these changes
Feb 21, 2024
paulgessinger
force-pushed
the
refactor/vtx-templates-part10-cpp-files
branch
from
9b220a3 to
51205fc
Compare
andiwand
approved these changes
Feb 21, 2024
🔴 Athena integration test results [e9ab1f7]🔴 Some tests have failed!Please investigate the pipeline! |
acts-project-service
added
the
Fails Athena tests
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
This PR moves the code of the `ImpactPointEstimator` from the header into a compiled file. To allow this, I have to make some changes to the interface to remove templates. In the process, I introduced `Eigen::Map<ActsDynamicVector>` as an argument to `getDistanceAndMomentum` and `getVertexCompatibility`. Part of: - #2842 Blocked by: - #2953
paulgessinger
removed
the
Fails Athena tests
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…#2953) This allows separate compilation, and should reduce memory footprint while compiling (as documented in acts-project#2842) They are: - `AdaptiveMultiVertexFitter` - `IterativeVertexFitter` - `AdaptiveGridDensityVertexFinder` - `ZScanVertexFinder` - `HelicalTrackLinearizer` - `FullBilloirVertexFitter` - `AdaptiveMultiVertexFinder` - `Vertex` - `GaussianTrackDensity` - `NumericalTrackLinearizer` Part of: - acts-project#2842 Blocked by: - acts-project#2952
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
This PR moves the code of the `ImpactPointEstimator` from the header into a compiled file. To allow this, I have to make some changes to the interface to remove templates. In the process, I introduced `Eigen::Map<ActsDynamicVector>` as an argument to `getDistanceAndMomentum` and `getVertexCompatibility`. Part of: - acts-project#2842 Blocked by: - acts-project#2953
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…#2953) This allows separate compilation, and should reduce memory footprint while compiling (as documented in acts-project#2842) They are: - `AdaptiveMultiVertexFitter` - `IterativeVertexFitter` - `AdaptiveGridDensityVertexFinder` - `ZScanVertexFinder` - `HelicalTrackLinearizer` - `FullBilloirVertexFitter` - `AdaptiveMultiVertexFinder` - `Vertex` - `GaussianTrackDensity` - `NumericalTrackLinearizer` Part of: - acts-project#2842 Blocked by: - acts-project#2952
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
This PR moves the code of the `ImpactPointEstimator` from the header into a compiled file. To allow this, I have to make some changes to the interface to remove templates. In the process, I introduced `Eigen::Map<ActsDynamicVector>` as an argument to `getDistanceAndMomentum` and `getVertexCompatibility`. Part of: - acts-project#2842 Blocked by: - acts-project#2953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows separate compilation, and should reduce memory footprint while compiling (as documented in #2842)
They are:
AdaptiveMultiVertexFitterIterativeVertexFitterAdaptiveGridDensityVertexFinderZScanVertexFinderHelicalTrackLinearizerFullBilloirVertexFitterAdaptiveMultiVertexFinderVertexGaussianTrackDensityNumericalTrackLinearizerPart of:
Blocked by: