Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Downgrade RootParticleWriter log message #2958

Merged

Conversation

paulgessinger
Copy link
Member

In ttbar / g4 jobs especially, we have many particles without hits. The INFO level seems excessive for these cases.

In ttbar / g4 jobs especially, we have **many** particles without hits.
The `INFO` level seems excessive for these cases.
@paulgessinger paulgessinger added this to the next milestone Feb 19, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Feb 19, 2024
andiwand
andiwand previously approved these changes Feb 19, 2024
@andiwand
Copy link
Contributor

alternatively we could also fill 0 in this case I guess

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5d0890) 48.78% compared to head (1a9183a) 48.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2958   +/-   ##
=======================================
  Coverage   48.78%   48.78%           
=======================================
  Files         493      493           
  Lines       28914    28914           
  Branches    13752    13752           
=======================================
  Hits        14105    14105           
  Misses       4909     4909           
  Partials     9900     9900           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@paulgessinger
Copy link
Member Author

Output changed due to writing a 0. Can you go again @andiwand ?

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kodiakhq kodiakhq bot merged commit fc75469 into acts-project:main Feb 20, 2024
54 checks passed
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
In ttbar / g4 jobs especially, we have **many** particles without hits. The `INFO` level seems excessive for these cases.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
In ttbar / g4 jobs especially, we have **many** particles without hits. The `INFO` level seems excessive for these cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants