-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Downgrade RootParticleWriter log message #2958
fix: Downgrade RootParticleWriter log message #2958
Conversation
In ttbar / g4 jobs especially, we have **many** particles without hits. The `INFO` level seems excessive for these cases.
alternatively we could also fill 0 in this case I guess |
📊: Physics performance monitoring for 1a9183aphysmon summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2958 +/- ##
=======================================
Coverage 48.78% 48.78%
=======================================
Files 493 493
Lines 28914 28914
Branches 13752 13752
=======================================
Hits 14105 14105
Misses 4909 4909
Partials 9900 9900 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Output changed due to writing a 0. Can you go again @andiwand ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
In ttbar / g4 jobs especially, we have **many** particles without hits. The `INFO` level seems excessive for these cases.
In ttbar / g4 jobs especially, we have **many** particles without hits. The `INFO` level seems excessive for these cases.
In ttbar / g4 jobs especially, we have many particles without hits. The
INFO
level seems excessive for these cases.