fix(ci): default arguments definition in physmon #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Infrastructure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2962 +/- ##
=======================================
Coverage 48.82% 48.82%
=======================================
Files 496 496
Lines 28938 28938
Branches 13751 13751
=======================================
Hits 14130 14130
Misses 4909 4909
Partials 9899 9899 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for cb45587physmon summary
|
paulgessinger
approved these changes
Feb 19, 2024
acts-project-service
added
the
Breaks Athena build
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
Bash needs for the defaults the following syntax `VAR=${[number]:-default}` (`-` was missing). Now the variable `outdir` cannot be empty anymore and we don't need to check.
This does not change anything in the current setup, since we are always specifying both additional arguments.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
Bash needs for the defaults the following syntax `VAR=${[number]:-default}` (`-` was missing). Now the variable `outdir` cannot be empty anymore and we don't need to check.
This does not change anything in the current setup, since we are always specifying both additional arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bash needs for the defaults the following syntax
VAR=${[number]:-default}(-was missing). Now the variableoutdircannot be empty anymore and we don't need to check.This does not change anything in the current setup, since we are always specifying both additional arguments.