Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix!: Fix vertex finding for seeds with z=0 (#2917)" #2978

Closed
wants to merge 4 commits into from

Conversation

andiwand
Copy link
Contributor

to check if #2917 caused Athena output changes

@github-actions github-actions bot added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Vertexing Changes Performance labels Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 48.72%. Comparing base (6a25545) to head (20f0a31).

Files Patch % Lines
Core/src/Vertexing/AdaptiveMultiVertexFinder.cpp 25.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2978   +/-   ##
=======================================
  Coverage   48.72%   48.72%           
=======================================
  Files         493      493           
  Lines       28968    28968           
  Branches    13790    13790           
=======================================
  Hits        14114    14114           
  Misses       4930     4930           
  Partials     9924     9924           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Feb 21, 2024
@github-actions github-actions bot removed Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Feb 22, 2024
@andiwand andiwand closed this Feb 29, 2024
@andiwand andiwand deleted the revert-2917 branch February 29, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants