-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "fix!: Fix vertex finding for seeds with z=0
(#2917)"
#2978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Infrastructure
Changes to build tools, continous integration, ...
Vertexing
Changes Performance
labels
Feb 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
=======================================
Coverage 48.72% 48.72%
=======================================
Files 493 493
Lines 28968 28968
Branches 13790 13790
=======================================
Hits 14114 14114
Misses 4930 4930
Partials 9924 9924 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 20f0a31physmon summary
|
acts-project-service
added
the
Breaks Athena build
This PR breaks the Athena build
label
Feb 21, 2024
paulgessinger
force-pushed
the
revert-2917
branch
from
February 21, 2024 15:34
151f21f
to
dbdc5a3
Compare
)" This reverts commit 123746c.
…roject#2917)"" This reverts commit dbdc5a3.
andiwand
force-pushed
the
revert-2917
branch
from
February 22, 2024 08:10
dbdc5a3
to
3eb493f
Compare
github-actions
bot
removed
Infrastructure
Changes to build tools, continous integration, ...
Changes Performance
labels
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Component - Core
Affects the Core module
Vertexing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to check if #2917 caused Athena output changes