feat: Add kaon hypothesis to ParticleHypothesis

[plariono]

This adds the kaon hypothesis such that there's no need to define it by hand.

Currently:

kaon = acts.ParticleHypothesis(321, 0.493677, 1)

>>> import acts
>>> kaon = acts.ParticleHypothesis(321, 0.493677, 1)
>>> kaon.absolutePdg()
<PdgParticle.???: 321>
>>> 

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 48.69%. Comparing base (9854009) to head (3df842b).

Files	Patch %	Lines
Core/src/Definitions/ParticleData.cpp	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2990      +/-   ##
==========================================
- Coverage   48.70%   48.69%   -0.01%     
==========================================
  Files         493      493              
  Lines       28976    28978       +2     
  Branches    13798    13799       +1     
==========================================
  Hits        14112    14112              
- Misses       4935     4937       +2     
  Partials     9929     9929              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 3df842b

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[paulgessinger]

Some test failures are still present here.

[plariono]

@paulgessinger @andiwand can you suggest what should be done for these failed tests to get them passed?

[andiwand]

@paulgessinger @andiwand can you suggest what should be done for these failed tests to get them passed?

>       assert str(kaon) == "ParticleHypothesis{absPdg=K, mass=0.493677, absCharge=1}"
E       AssertionError: assert 'ParticleHypo... absCharge=1}' == 'ParticleHypo... absCharge=1}'
E         
E         - ParticleHypothesis{absPdg=K, mass=0.493677, absCharge=1}
E         + ParticleHypothesis{absPdg=K+, mass=0.493677, absCharge=1}
E         ?                            +

it expects K+ instead of K

either you just change the assert or you specialize kaons here https://github.com/acts-project/acts/blob/main/Core/src/Definitions/ParticleData.cpp#L109

[plariono]

@paulgessinger @andiwand can you suggest what should be done for these failed tests to get them passed?

>       assert str(kaon) == "ParticleHypothesis{absPdg=K, mass=0.493677, absCharge=1}"
E       AssertionError: assert 'ParticleHypo... absCharge=1}' == 'ParticleHypo... absCharge=1}'
E         
E         - ParticleHypothesis{absPdg=K, mass=0.493677, absCharge=1}
E         + ParticleHypothesis{absPdg=K+, mass=0.493677, absCharge=1}
E         ?                            +

it expects K+ instead of K

either you just change the assert or you specialize kaons here https://github.com/acts-project/acts/blob/main/Core/src/Definitions/ParticleData.cpp#L109

Thank you @andiwand, should be fixed now.

[andiwand]

one more error popped up @plariono

    def test_pgd_particle():
>       assert len(acts.PdgParticle.__members__) == 17
E       AssertionError: assert 19 == 17
E        +  where 19 = len({'eAntiElectron': <PdgParticle.eAntiElectron: -11>, 'eAntiMuon': <PdgParticle.eAntiMuon: -13>, 'eAntiNeutron': <PdgParticle.eAntiNeutron: -2112>, 'eAntiProton': <PdgParticle.eAntiProton: -2212>, ...})
E        +    where {'eAntiElectron': <PdgParticle.eAntiElectron: -11>, 'eAntiMuon': <PdgParticle.eAntiMuon: -13>, 'eAntiNeutron': <PdgParticle.eAntiNeutron: -2112>, 'eAntiProton': <PdgParticle.eAntiProton: -2212>, ...} = <class 'acts.ActsPythonBindings.PdgParticle'>.__members__
E        +      where <class 'acts.ActsPythonBindings.PdgParticle'> = acts.PdgParticle

Examples/Python/tests/test_base.py:15: AssertionError
=========================== short test summary info ============================
FAILED Examples/Python/tests/test_base.py::test_pgd_particle - AssertionError: assert 19 == 17
 +  where 19 = len({'eAntiElectron': <PdgParticle.eAntiElectron: -11>, 'eAntiMuon': <PdgParticle.eAntiMuon: -13>, 'eAntiNeutron': <PdgParticle.eAntiNeutron: -2112>, 'eAntiProton': <PdgParticle.eAntiProton: -2212>, ...})
 +    where {'eAntiElectron': <PdgParticle.eAntiElectron: -11>, 'eAntiMuon': <PdgParticle.eAntiMuon: -13>, 'eAntiNeutron': <PdgParticle.eAntiNeutron: -2112>, 'eAntiProton': <PdgParticle.eAntiProton: -2212>, ...} = <class 'acts.ActsPythonBindings.PdgParticle'>.__members__
 +      where <class 'acts.ActsPythonBindings.PdgParticle'> = acts.PdgParticle

[acts-project-service]

✅ Athena integration test results

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	test_ActsEFTrackFit
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsConversionWorkflow
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco

[paulgessinger]

Athena failure was unrelated. No action required.