Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix potential interaction with GeoModel's bundled json #2995

Merged

Conversation

paulgessinger
Copy link
Member

GeoModel also bundles JSON. This adds a patch to our bundled GeoModel that allows us to instruct them to not build their own JSON. This should be upstreamed to GeoModel at some point.

@paulgessinger paulgessinger added this to the next milestone Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.69%. Comparing base (f2a19a6) to head (34cf300).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2995   +/-   ##
=======================================
  Coverage   48.69%   48.69%           
=======================================
  Files         493      493           
  Lines       28980    28980           
  Branches    13800    13800           
=======================================
  Hits        14112    14112           
  Misses       4939     4939           
  Partials     9929     9929           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 3d96535 into acts-project:main Mar 1, 2024
54 checks passed
@github-actions github-actions bot removed the automerge label Mar 1, 2024
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Mar 1, 2024
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Mar 6, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Mar 7, 2024
…roject#2995)

GeoModel also bundles JSON. This adds a patch to our bundled GeoModel that allows us to instruct them to not build their own JSON. This should be upstreamed to GeoModel at some point.
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…roject#2995)

GeoModel also bundles JSON. This adds a patch to our bundled GeoModel that allows us to instruct them to not build their own JSON. This should be upstreamed to GeoModel at some point.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…roject#2995)

GeoModel also bundles JSON. This adds a patch to our bundled GeoModel that allows us to instruct them to not build their own JSON. This should be upstreamed to GeoModel at some point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants