Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gx2f): add error message to NotEnoughMeasurements #3003

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

AJPfleger
Copy link
Contributor

I forgot to add the error message in PR #2981.

@AJPfleger AJPfleger added this to the next milestone Feb 29, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Track Fitting labels Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 48.69%. Comparing base (6c910b0) to head (33bf1a6).

Files Patch % Lines
...re/src/TrackFitting/GlobalChiSquareFitterError.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3003      +/-   ##
==========================================
- Coverage   48.69%   48.69%   -0.01%     
==========================================
  Files         493      493              
  Lines       28978    28980       +2     
  Branches    13799    13800       +1     
==========================================
  Hits        14112    14112              
- Misses       4937     4939       +2     
  Partials     9929     9929              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 6ef4e4e into acts-project:main Feb 29, 2024
57 checks passed
@AJPfleger AJPfleger deleted the not-enough-measurements branch February 29, 2024 20:04
@paulgessinger paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Mar 7, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants