-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use track weight for vertex truth matching in Examples #3024
Merged
kodiakhq
merged 11 commits into
acts-project:main
from
andiwand:ex-vtxperf-refactor-matching
Mar 15, 2024
Merged
refactor: Use track weight for vertex truth matching in Examples #3024
kodiakhq
merged 11 commits into
acts-project:main
from
andiwand:ex-vtxperf-refactor-matching
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3024 +/- ##
=======================================
Coverage 48.83% 48.83%
=======================================
Files 491 491
Lines 28889 28889
Branches 13711 13711
=======================================
Hits 14107 14107
Misses 4956 4956
Partials 9826 9826 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 78895aephysmon summary
|
github-actions
bot
added
the
Infrastructure
Changes to build tools, continous integration, ...
label
Mar 13, 2024
AJPfleger
approved these changes
Mar 15, 2024
dimitra97
pushed a commit
to dimitra97/acts
that referenced
this pull request
Mar 19, 2024
…s-project#3024) Since tracks at vertices have weights we should use that instead of occurrence to decide on the truth matching. Apart from that I renamed the matching thresholds and branches to be more comprehensible.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…s-project#3024) Since tracks at vertices have weights we should use that instead of occurrence to decide on the truth matching. Apart from that I renamed the matching thresholds and branches to be more comprehensible.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…s-project#3024) Since tracks at vertices have weights we should use that instead of occurrence to decide on the truth matching. Apart from that I renamed the matching thresholds and branches to be more comprehensible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes Performance
Component - Examples
Affects the Examples module
Infrastructure
Changes to build tools, continous integration, ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since tracks at vertices have weights we should use that instead of occurrence to decide on the truth matching.
Apart from that I renamed the matching thresholds and branches to be more comprehensible.