Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use track weight for vertex truth matching in Examples #3024

Merged
merged 11 commits into from
Mar 15, 2024

Conversation

andiwand
Copy link
Contributor

Since tracks at vertices have weights we should use that instead of occurrence to decide on the truth matching.

Apart from that I renamed the matching thresholds and branches to be more comprehensible.

@andiwand andiwand added this to the next milestone Mar 12, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.83%. Comparing base (4cb1e5b) to head (78895ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3024   +/-   ##
=======================================
  Coverage   48.83%   48.83%           
=======================================
  Files         491      491           
  Lines       28889    28889           
  Branches    13711    13711           
=======================================
  Hits        14107    14107           
  Misses       4956     4956           
  Partials     9826     9826           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Mar 13, 2024
@kodiakhq kodiakhq bot merged commit 49e815c into acts-project:main Mar 15, 2024
54 checks passed
@andiwand andiwand deleted the ex-vtxperf-refactor-matching branch March 16, 2024 08:15
dimitra97 pushed a commit to dimitra97/acts that referenced this pull request Mar 19, 2024
…s-project#3024)

Since tracks at vertices have weights we should use that instead of occurrence to decide on the truth matching.

Apart from that I renamed the matching thresholds and branches to be more comprehensible.
@paulgessinger paulgessinger modified the milestones: next, v33.1.0 Mar 26, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…s-project#3024)

Since tracks at vertices have weights we should use that instead of occurrence to decide on the truth matching.

Apart from that I renamed the matching thresholds and branches to be more comprehensible.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…s-project#3024)

Since tracks at vertices have weights we should use that instead of occurrence to decide on the truth matching.

Apart from that I renamed the matching thresholds and branches to be more comprehensible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Performance Component - Examples Affects the Examples module Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants