feat: Geant4SurfaceProvider optimization #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssdetlab
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3025 +/- ##
=======================================
Coverage 48.82% 48.82%
=======================================
Files 489 489
Lines 28860 28860
Branches 13695 13695
=======================================
Hits 14092 14092
Misses 4953 4953
Partials 9815 9815 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 81d14b8physmon summary
|
andiwand
previously approved these changes
Mar 18, 2024
|
this does not compile anymore @ssdetlab. can you take a look? |
|
As I mentioned in #3038, it was going to merge a test that is not compatible with the interface changes I propose here. Should be minor, so will fix soon |
andiwand
approved these changes
Mar 19, 2024
acts-project-service
added
the
Breaks Athena build
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
Introducing minor changes to the `Geant4SurfaceProvider` targeting optimization and utility for Telescope-style use cases. The first change is the removal of the Gdml parsing from the construction in favor of supplying a pointer to the world volume. The Internal Structure Builder is called (potentially) multiple times in the builder pipeline, so, before the changes, the description was also parsed multiple times and several Worlds were kept in the memory. The second change has to do with the conventional z-orientation of the Telescope geometries. There's a need to rotate the geometries away from the z-axis in the current implementation of the track parametrization, so a simple way of applying a global transformation at the construction stage is introduced. In our experience, the cleanest way to do it is on the Geant4 volumes conversion stage, thus the additional `G4Transform` is included into the `Config`.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
Introducing minor changes to the `Geant4SurfaceProvider` targeting optimization and utility for Telescope-style use cases. The first change is the removal of the Gdml parsing from the construction in favor of supplying a pointer to the world volume. The Internal Structure Builder is called (potentially) multiple times in the builder pipeline, so, before the changes, the description was also parsed multiple times and several Worlds were kept in the memory. The second change has to do with the conventional z-orientation of the Telescope geometries. There's a need to rotate the geometries away from the z-axis in the current implementation of the track parametrization, so a simple way of applying a global transformation at the construction stage is introduced. In our experience, the cleanest way to do it is on the Geant4 volumes conversion stage, thus the additional `G4Transform` is included into the `Config`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing minor changes to the
Geant4SurfaceProvidertargeting optimization and utility for Telescope-style use cases.The first change is the removal of the Gdml parsing from the construction in favor of supplying a pointer to the world volume. The Internal Structure Builder is called (potentially) multiple times in the builder pipeline, so, before the changes, the description was also parsed multiple times and several Worlds were kept in the memory.
The second change has to do with the conventional z-orientation of the Telescope geometries. There's a need to rotate the geometries away from the z-axis in the current implementation of the track parametrization, so a simple way of applying a global transformation at the construction stage is introduced. In our experience, the cleanest way to do it is on the Geant4 volumes conversion stage, thus the additional
G4Transformis included into theConfig.