chore: Remove explicit (bin0/bin1) access to MaterialSlab #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3028 +/- ##
==========================================
- Coverage 48.83% 48.83% -0.01%
==========================================
Files 491 491
Lines 28893 28889 -4
Branches 13705 13711 +6
==========================================
- Hits 14111 14107 -4
- Misses 4954 4956 +2
+ Partials 9828 9826 -2 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 2c247f5physmon summary
|
|
Hi @ssdetlab - this is a tiny PR in preparation for the GridSurfaceMaterial, it removes an interface method that only makes sense for one specific implementation. |
ssdetlab
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Looks good to me.
@asalzburger, I think that for the policy-bot to be satisfied I need to be on the reviewers list. I'll send the request
andiwand
reviewed
Mar 15, 2024
dimitra97
pushed a commit
to dimitra97/acts
that referenced
this pull request
Mar 19, 2024
…ct#3028) This PR removes the explicit: `materialSlab(std::size_t bin0, std::size_t bin1)` access from the `ISurfaceMaterial` base class (and the derived classes), because it only makes sense for `BinnedSurfaceMaterial `, and not for other surface material versions. In all cases this was used, it was clear that you had `BinnedSurfaceMaterial` in hand, so you could directly access the `fullMaterial()` matrix.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…ct#3028) This PR removes the explicit: `materialSlab(std::size_t bin0, std::size_t bin1)` access from the `ISurfaceMaterial` base class (and the derived classes), because it only makes sense for `BinnedSurfaceMaterial `, and not for other surface material versions. In all cases this was used, it was clear that you had `BinnedSurfaceMaterial` in hand, so you could directly access the `fullMaterial()` matrix.
asalzburger
added a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…ct#3028) This PR removes the explicit: `materialSlab(std::size_t bin0, std::size_t bin1)` access from the `ISurfaceMaterial` base class (and the derived classes), because it only makes sense for `BinnedSurfaceMaterial `, and not for other surface material versions. In all cases this was used, it was clear that you had `BinnedSurfaceMaterial` in hand, so you could directly access the `fullMaterial()` matrix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the explicit:
materialSlab(std::size_t bin0, std::size_t bin1)access from theISurfaceMaterialbase class (and the derived classes), because it only makes sense forBinnedSurfaceMaterial, and not for other surface material versions.In all cases this was used, it was clear that you had
BinnedSurfaceMaterialin hand, so you could directly access thefullMaterial()matrix.