Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct install RPATH in Python example bindings #3040

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

ntadej
Copy link
Contributor

@ntadej ntadej commented Mar 19, 2024

Trying to setup the example full chain using python I realised that the installation is not OK. There was a missing/ in the install RPATH. This should fix it.

@github-actions github-actions bot added the Component - Examples Affects the Examples module label Mar 19, 2024
@andiwand andiwand added this to the next milestone Mar 19, 2024
@andiwand
Copy link
Contributor

we will need gitlab runner permissions for this one @paulgessinger

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.83%. Comparing base (69f7217) to head (4f044b5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3040   +/-   ##
=======================================
  Coverage   48.83%   48.83%           
=======================================
  Files         491      491           
  Lines       28886    28886           
  Branches    13708    13708           
=======================================
  Hits        14107    14107           
  Misses       4954     4954           
  Partials     9825     9825           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger
Copy link
Member

Added @ntadej to the CI perms group.

@kodiakhq kodiakhq bot merged commit 9c9bedd into acts-project:main Mar 19, 2024
54 checks passed
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Mar 19, 2024
@CarloVarni CarloVarni removed the Breaks Athena build This PR breaks the Athena build label Mar 21, 2024
@paulgessinger paulgessinger modified the milestones: next, v33.1.0 Mar 26, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
)

Trying to setup the example full chain using python I realised that the installation is not OK. There was a missing`/` in the install `RPATH`. This should fix it.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
)

Trying to setup the example full chain using python I realised that the installation is not OK. There was a missing`/` in the install `RPATH`. This should fix it.
@ntadej ntadej deleted the fix-rpath branch June 4, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants