-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add json IO for GridAccess delegates #3047
feat: add json IO for GridAccess delegates #3047
Conversation
d2c4cc5
to
ecf8f04
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3047 +/- ##
=======================================
Coverage 48.82% 48.82%
=======================================
Files 491 491
Lines 28909 28909
Branches 13724 13724
=======================================
Hits 14114 14114
Misses 4956 4956
Partials 9839 9839 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a big fan of 1-3 letter acronym variables (ga
, jga
, la
, jla
, j
, t
). Could it make sense to find more descriptive names?
📊: Physics performance monitoring for 30b4a6fphysmon summary
|
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This PR adds the json IO for the grid access delegates, so that they can be used for writing material files and navigation IO formats.
This PR adds the json IO for the grid access delegates, so that they can be used for writing material files and navigation IO formats.
This PR adds the json IO for the grid access delegates, so that they can be used for writing material files and navigation IO formats.