Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add json IO for GridAccess delegates #3047

Merged

Conversation

asalzburger
Copy link
Contributor

This PR adds the json IO for the grid access delegates, so that they can be used for writing material files and navigation IO formats.

@asalzburger asalzburger added this to the next milestone Mar 20, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins labels Mar 20, 2024
@asalzburger asalzburger force-pushed the feat-global-local-access-grid-io branch from d2c4cc5 to ecf8f04 Compare March 20, 2024 14:51
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.82%. Comparing base (e9ea680) to head (38b09fa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3047   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files         491      491           
  Lines       28909    28909           
  Branches    13724    13724           
=======================================
  Hits        14114    14114           
  Misses       4956     4956           
  Partials     9839     9839           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of 1-3 letter acronym variables (ga, jga, la, jla, j, t). Could it make sense to find more descriptive names?

Plugins/Json/src/GridJsonConverter.cpp Outdated Show resolved Hide resolved
Plugins/Json/src/GridJsonConverter.cpp Outdated Show resolved Hide resolved
Core/include/Acts/Utilities/GridAccessHelpers.hpp Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Component - Core Affects the Core module label Mar 21, 2024
@asalzburger asalzburger requested a review from AJPfleger March 21, 2024 14:05
Plugins/Json/src/GridJsonConverter.cpp Outdated Show resolved Hide resolved
Plugins/Json/src/GridJsonConverter.cpp Outdated Show resolved Hide resolved
Plugins/Json/src/GridJsonConverter.cpp Show resolved Hide resolved
Tests/UnitTests/Plugins/Json/GridJsonConverterTests.cpp Outdated Show resolved Hide resolved
Tests/UnitTests/Plugins/Json/GridJsonConverterTests.cpp Outdated Show resolved Hide resolved
Plugins/Json/src/GridJsonConverter.cpp Outdated Show resolved Hide resolved
asalzburger and others added 5 commits March 21, 2024 22:12
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
@asalzburger asalzburger requested a review from AJPfleger March 21, 2024 21:19
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kodiakhq kodiakhq bot merged commit 0982f68 into acts-project:main Mar 21, 2024
56 checks passed
@paulgessinger paulgessinger modified the milestones: next, v33.1.0 Mar 26, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
This PR adds the json IO for the grid access delegates, so that they can be used for writing material files and navigation IO formats.
asalzburger added a commit to asalzburger/acts that referenced this pull request May 21, 2024
This PR adds the json IO for the grid access delegates, so that they can be used for writing material files and navigation IO formats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants