-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove empty style guide and fix gender neutral language #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3049 +/- ##
=======================================
Coverage 48.82% 48.82%
=======================================
Files 491 491
Lines 28909 28909
Branches 13724 13724
=======================================
Hits 14114 14114
Misses 4956 4956
Partials 9839 9839 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for b0753ccphysmon summary
|
asalzburger
approved these changes
Mar 21, 2024
🔴 Athena integration test results [e9ea680]🔴 Some tests have failed!Please investigate the pipeline! |
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Mar 21, 2024
andiwand
removed
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Apr 10, 2024
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…project#3049) The (empty) style guide seems to be unnecessary, since we already have a separate section [Code guidelines](https://acts.readthedocs.io/en/v33.0.0/codeguide.html) and also talk about formatting in the [Contribution guidelines](https://acts.readthedocs.io/en/v33.0.0/contribution/guide.html#contribution-guidelines).
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…project#3049) The (empty) style guide seems to be unnecessary, since we already have a separate section [Code guidelines](https://acts.readthedocs.io/en/v33.0.0/codeguide.html) and also talk about formatting in the [Contribution guidelines](https://acts.readthedocs.io/en/v33.0.0/contribution/guide.html#contribution-guidelines).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (empty) style guide seems to be unnecessary, since we already have a separate section Code guidelines and also talk about formatting in the Contribution guidelines.