Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: TrackingVolume and Volume interface + functionality #3064

Merged

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Mar 27, 2024

This PR:

  • Marks all of the Gen1 interface of TrackingVolume as such, to indicate what we'll supersede in the future
  • Makes a slight adjustment to TransformRange, for
  • Add internal vector of uniquely owned child TrackingVolumes in TrackingVolume, accessible in a const-preserving way through TransformRange.
  • Updates the TrackingVolume constructors, eliminating one convenience one we don't need, and start adding ones we'll use for Gen3

Blocked by:

@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Mar 27, 2024
@paulgessinger paulgessinger added this to the next milestone Mar 27, 2024
@paulgessinger paulgessinger changed the title feat: Add TransformRange helper refactor: TrackingVolume and Volume interface + functionality Mar 27, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 49.12%. Comparing base (bdf9ae1) to head (f729bce).

❗ Current head f729bce differs from pull request most recent head a8c8a10. Consider uploading reports for the commit a8c8a10 to get more accurate results

Files Patch % Lines
Core/src/Geometry/Volume.cpp 42.10% 9 Missing and 2 partials ⚠️
Core/src/Geometry/TrackingVolume.cpp 66.66% 4 Missing and 2 partials ⚠️
Core/include/Acts/Geometry/TrackingVolume.hpp 50.00% 0 Missing and 1 partial ⚠️
Core/src/Geometry/CuboidVolumeBuilder.cpp 50.00% 0 Missing and 1 partial ⚠️
Core/src/Geometry/CylinderVolumeHelper.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3064      +/-   ##
==========================================
+ Coverage   49.10%   49.12%   +0.02%     
==========================================
  Files         501      501              
  Lines       29295    29244      -51     
  Branches    13906    13862      -44     
==========================================
- Hits        14385    14367      -18     
- Misses       4956     4957       +1     
+ Partials     9954     9920      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger paulgessinger force-pushed the refactor/geometry/3/volume-updates-pt2 branch from 60f0e26 to 2b82f93 Compare March 27, 2024 18:00
@paulgessinger paulgessinger marked this pull request as ready for review March 27, 2024 18:01
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Mar 27, 2024
@paulgessinger paulgessinger requested a review from andiwand March 28, 2024 07:54
andiwand
andiwand previously approved these changes Mar 28, 2024
Core/include/Acts/Geometry/TrackingVolume.hpp Show resolved Hide resolved
Core/include/Acts/Geometry/Volume.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Geometry/Volume.hpp Show resolved Hide resolved
@paulgessinger paulgessinger force-pushed the refactor/geometry/3/volume-updates-pt2 branch from be31521 to d9c97f4 Compare April 8, 2024 10:55
andiwand
andiwand previously approved these changes Apr 16, 2024
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

should this be marked as breaking?

Core/include/Acts/Geometry/TrackingVolume.hpp Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 12b8611 into acts-project:main Apr 23, 2024
51 checks passed
@andiwand andiwand modified the milestones: next, v34.1.0 Apr 25, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
…roject#3064)

This PR:
- Marks all of the Gen1 interface of `TrackingVolume` as such, to indicate what we'll supersede in the future
- Makes a slight adjustment to [`TransformRange`](acts-project#3060), for
- Add internal vector of uniquely owned child `TrackingVolume`s in `TrackingVolume`, accessible in a const-preserving way through `TransformRange`.
- Updates the `TrackingVolume` constructors, eliminating one convenience one we don't need, and start adding ones we'll use for Gen3

Blocked by:
- acts-project#3060
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
…roject#3064)

This PR:
- Marks all of the Gen1 interface of `TrackingVolume` as such, to indicate what we'll supersede in the future
- Makes a slight adjustment to [`TransformRange`](acts-project#3060), for
- Add internal vector of uniquely owned child `TrackingVolume`s in `TrackingVolume`, accessible in a const-preserving way through `TransformRange`.
- Updates the `TrackingVolume` constructors, eliminating one convenience one we don't need, and start adding ones we'll use for Gen3

Blocked by:
- acts-project#3060
@paulgessinger paulgessinger mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants