-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: TrackingVolume and Volume interface + functionality #3064
refactor: TrackingVolume and Volume interface + functionality #3064
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3064 +/- ##
==========================================
+ Coverage 49.10% 49.12% +0.02%
==========================================
Files 501 501
Lines 29295 29244 -51
Branches 13906 13862 -44
==========================================
- Hits 14385 14367 -18
- Misses 4956 4957 +1
+ Partials 9954 9920 -34 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for a8c8a10physmon summary
|
60f0e26
to
2b82f93
Compare
be31521
to
d9c97f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me 👍
should this be marked as breaking?
…roject#3064) This PR: - Marks all of the Gen1 interface of `TrackingVolume` as such, to indicate what we'll supersede in the future - Makes a slight adjustment to [`TransformRange`](acts-project#3060), for - Add internal vector of uniquely owned child `TrackingVolume`s in `TrackingVolume`, accessible in a const-preserving way through `TransformRange`. - Updates the `TrackingVolume` constructors, eliminating one convenience one we don't need, and start adding ones we'll use for Gen3 Blocked by: - acts-project#3060
…roject#3064) This PR: - Marks all of the Gen1 interface of `TrackingVolume` as such, to indicate what we'll supersede in the future - Makes a slight adjustment to [`TransformRange`](acts-project#3060), for - Add internal vector of uniquely owned child `TrackingVolume`s in `TrackingVolume`, accessible in a const-preserving way through `TransformRange`. - Updates the `TrackingVolume` constructors, eliminating one convenience one we don't need, and start adding ones we'll use for Gen3 Blocked by: - acts-project#3060
This PR:
TrackingVolume
as such, to indicate what we'll supersede in the futureTransformRange
, forTrackingVolume
s inTrackingVolume
, accessible in a const-preserving way throughTransformRange
.TrackingVolume
constructors, eliminating one convenience one we don't need, and start adding ones we'll use for Gen3Blocked by: