Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move parameter transform helpers out of detail:: #3070

Merged
merged 3 commits into from
Apr 4, 2024
Merged

refactor: Move parameter transform helpers out of detail:: #3070

merged 3 commits into from
Apr 4, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Apr 2, 2024

These helpers are extensively used outside Acts.

@andiwand andiwand added this to the next milestone Apr 2, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Fatras Affects the Fatras module Component - Examples Affects the Examples module Event Data Model Track Fitting labels Apr 2, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 27.02703% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 49.06%. Comparing base (6ba2e2d) to head (bd8dd2f).

Files Patch % Lines
Core/src/EventData/TransformationHelpers.cpp 36.84% 0 Missing and 12 partials ⚠️
Core/src/Propagator/detail/CovarianceEngine.cpp 0.00% 1 Missing and 2 partials ⚠️
...ude/Acts/EventData/GenericBoundTrackParameters.hpp 33.33% 0 Missing and 2 partials ⚠️
...ts/EventData/GenericCurvilinearTrackParameters.hpp 0.00% 0 Missing and 2 partials ⚠️
.../include/Acts/EventData/MultiTrajectoryHelpers.hpp 0.00% 0 Missing and 2 partials ⚠️
...c/EventData/CorrectedTransformationFreeToBound.cpp 0.00% 0 Missing and 2 partials ⚠️
...e/Acts/EventData/MultiComponentTrackParameters.hpp 0.00% 0 Missing and 1 partial ⚠️
Core/include/Acts/Propagator/AtlasStepper.hpp 50.00% 0 Missing and 1 partial ⚠️
Core/include/Acts/Propagator/EigenStepper.ipp 50.00% 0 Missing and 1 partial ⚠️
Core/src/Propagator/StraightLineStepper.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3070   +/-   ##
=======================================
  Coverage   49.05%   49.06%           
=======================================
  Files         495      494    -1     
  Lines       28972    28972           
  Branches    13739    13739           
=======================================
+ Hits        14213    14214    +1     
+ Misses       4923     4922    -1     
  Partials     9836     9836

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Apr 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited
Loading

📊: Physics performance monitoring for bd8dd2f

Full contents

physmon summary

@AJPfleger AJPfleger self-requested a review April 3, 2024 12:48
@acts-project-service
Copy link
Collaborator

acts-project-service commented Apr 3, 2024 •
edited
Loading

🔴 Athena integration test results [1549ccb]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Apr 3, 2024
@andiwand andiwand removed the Breaks Athena build This PR breaks the Athena build label Apr 3, 2024
@kodiakhq kodiakhq bot merged commit 1549ccb into acts-project:main Apr 4, 2024
55 checks passed
@andiwand andiwand deleted the refactor-public-param-transform-helpers branch April 4, 2024 07:21
@github-actions github-actions bot removed the automerge label Apr 4, 2024
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Apr 4, 2024
@andiwand andiwand removed the Breaks Athena build This PR breaks the Athena build label Apr 10, 2024
@andiwand andiwand modified the milestones: next, v34.0.0 Apr 15, 2024
Ragansu pushed a commit to Ragansu/acts that referenced this pull request Apr 19, 2024
@andiwand @Ragansu
refactor: Move parameter transform helpers out of detail:: (acts-pr…
bba478f 
…oject#3070)

These helpers are extensively used outside Acts.
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@andiwand @EleniXoch
refactor: Move parameter transform helpers out of detail:: (acts-pr…
e348dc0 
…oject#3070)

These helpers are extensively used outside Acts.
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@andiwand @asalzburger
refactor: Move parameter transform helpers out of detail:: (acts-pr…
5877796 
…oject#3070)

These helpers are extensively used outside Acts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins Event Data Model Track Fitting
Projects
None yet
Milestone
v34.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andiwand @acts-project-service @AJPfleger