refactor: rewrite measurement selector

[CarloVarni]

Changes to improve the measurement selector

/cc @andiwand and @goetzgaycken

[CarloVarni]

First changes from a quick look. Will do more later (that is why this is a draft for now)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 49.02%. Comparing base (1374baa) to head (f67393d).
Report is 5 commits behind head on main.

❗ Current head f67393d differs from pull request most recent head 7e63e63. Consider uploading reports for the commit 7e63e63 to get more accurate results

Files	Patch %	Lines
Core/src/TrackFinding/MeasurementSelector.cpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3083   +/-   ##
=======================================
  Coverage   49.02%   49.02%           
=======================================
  Files         494      494           
  Lines       29058    29059    +1     
  Branches    13797    13797           
=======================================
+ Hits        14246    14247    +1     
  Misses       4929     4929           
  Partials     9883     9883           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 7e63e63

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[CarloVarni]

@andiwand of course @paulgessinger was correct about the map types, so I reverted the changes on passing by reference for those.

I have applied additional changed to the function but I'm afraid this is not coming with an executing time improvement. I still think the new function is cleaner and easier to understand, so I'd like to push it anyway into ACTS

[andiwand]

Good from my side 👍

I think @goetzgaycken optimized this code recently

[acts-project-service]

✅ Athena integration test results [3203649]

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsConversionWorkflow
🟢	test_ActsWorkflowFastTracking
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco