ci: Add clang-tidy check for nested namespace definitions #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3084 +/- ##
=======================================
Coverage 49.02% 49.02%
=======================================
Files 494 494
Lines 29058 29058
Branches 13797 13797
=======================================
Hits 14246 14246
Misses 4929 4929
Partials 9883 9883 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 99f9ce8physmon summary
|
github-actions
bot
added
the
Infrastructure
github-actions
bot
removed
the
Infrastructure
github-actions
bot
added
the
Infrastructure
github-actions
bot
added
Component - Core
andiwand
approved these changes
Apr 8, 2024
🔴 Athena integration test results [6883f31]🔴 Some tests have failed!Please investigate the pipeline! |
acts-project-service
added
Breaks Athena build
andiwand
removed
Breaks Athena build
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
…ct#3084) New language feature in C++17: Nested namespace definitions, e.g., `namespace X::Y { … }` instead of `namespace X { namespace Y { … } }` We had a good mix between them, but clang-tidy has with `modernize-concat-nested-namespaces` an option, to automatically check for them. I stumbled over this, when reading through the cpp-standard-updates and I think this improves readability. Hits will be reported similar to this one: ``` ╭─ /builds/acts/ci-bridge/src/Tests/UnitTests/Plugins/TGeo/TGeoParserTests.cpp─╮ │ 🟡 │ │ /builds/acts/ci-bridge/src/Tests/UnitTests/Plugins/TGeo/TGeoParserTests.cpp: │ │ 27:1 WARNING [modernize-concat-nested-namespaces] │ │ ╭──────────────────────────────────────────────────────────────────────────╮ │ │ │ nested namespaces can be concatenated │ │ │ │ 27 | namespace Acts { │ │ │ │ | ^~~~~~~~~~~~~~~~ │ │ │ │ 28 | │ │ │ │ 29 | namespace Test { │ │ │ │ | ~~~~~~~~~~~~~~ │ │ │ │ | namespace Acts::Test │ │ │ │ │ │ │ ╰──────────────────────────────────────────────────────────────────────────╯ │ │ ──────────────────────────────────────────────────────────────────────────── │ ╰──────────────────────────────────────────────────────────────────────────────╯ ```
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…ct#3084) New language feature in C++17: Nested namespace definitions, e.g., `namespace X::Y { … }` instead of `namespace X { namespace Y { … } }` We had a good mix between them, but clang-tidy has with `modernize-concat-nested-namespaces` an option, to automatically check for them. I stumbled over this, when reading through the cpp-standard-updates and I think this improves readability. Hits will be reported similar to this one: ``` ╭─ /builds/acts/ci-bridge/src/Tests/UnitTests/Plugins/TGeo/TGeoParserTests.cpp─╮ │ 🟡 │ │ /builds/acts/ci-bridge/src/Tests/UnitTests/Plugins/TGeo/TGeoParserTests.cpp: │ │ 27:1 WARNING [modernize-concat-nested-namespaces] │ │ ╭──────────────────────────────────────────────────────────────────────────╮ │ │ │ nested namespaces can be concatenated │ │ │ │ 27 | namespace Acts { │ │ │ │ | ^~~~~~~~~~~~~~~~ │ │ │ │ 28 | │ │ │ │ 29 | namespace Test { │ │ │ │ | ~~~~~~~~~~~~~~ │ │ │ │ | namespace Acts::Test │ │ │ │ │ │ │ ╰──────────────────────────────────────────────────────────────────────────╯ │ │ ──────────────────────────────────────────────────────────────────────────── │ ╰──────────────────────────────────────────────────────────────────────────────╯ ```
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…ct#3084) New language feature in C++17: Nested namespace definitions, e.g., `namespace X::Y { … }` instead of `namespace X { namespace Y { … } }` We had a good mix between them, but clang-tidy has with `modernize-concat-nested-namespaces` an option, to automatically check for them. I stumbled over this, when reading through the cpp-standard-updates and I think this improves readability. Hits will be reported similar to this one: ``` ╭─ /builds/acts/ci-bridge/src/Tests/UnitTests/Plugins/TGeo/TGeoParserTests.cpp─╮ │ 🟡 │ │ /builds/acts/ci-bridge/src/Tests/UnitTests/Plugins/TGeo/TGeoParserTests.cpp: │ │ 27:1 WARNING [modernize-concat-nested-namespaces] │ │ ╭──────────────────────────────────────────────────────────────────────────╮ │ │ │ nested namespaces can be concatenated │ │ │ │ 27 | namespace Acts { │ │ │ │ | ^~~~~~~~~~~~~~~~ │ │ │ │ 28 | │ │ │ │ 29 | namespace Test { │ │ │ │ | ~~~~~~~~~~~~~~ │ │ │ │ | namespace Acts::Test │ │ │ │ │ │ │ ╰──────────────────────────────────────────────────────────────────────────╯ │ │ ──────────────────────────────────────────────────────────────────────────── │ ╰──────────────────────────────────────────────────────────────────────────────╯ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New language feature in C++17:
Nested namespace definitions, e.g.,
namespace X::Y { … }instead ofnamespace X { namespace Y { … } }We had a good mix between them, but clang-tidy has with
modernize-concat-nested-namespacesan option, to automatically check for them.I stumbled over this, when reading through the cpp-standard-updates and I think this improves readability.
Hits will be reported similar to this one: