-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial sigma qop
coefficients for Examples TrackParamsEstimationAlgorithm
#3111
Merged
kodiakhq
merged 6 commits into
acts-project:main
from
andiwand:ex-feat-initial-sigma-qop-coefficients
Apr 18, 2024
Merged
feat: Initial sigma qop
coefficients for Examples TrackParamsEstimationAlgorithm
#3111
kodiakhq
merged 6 commits into
acts-project:main
from
andiwand:ex-feat-initial-sigma-qop-coefficients
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Examples
Affects the Examples module
Track Finding
labels
Apr 17, 2024
📊: Physics performance monitoring for 4959d7ephysmon summary
|
github-actions
bot
added
Infrastructure
Changes to build tools, continous integration, ...
Changes Performance
labels
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to say about the code ! Did you check how this affect the pull of qop ?
Corentin-Allaire
previously approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then lets go !
acts-policybot
bot
dismissed
Corentin-Allaire’s stale review
April 18, 2024 15:46
Invalidated by push of 0cf6533
Corentin-Allaire
approved these changes
Apr 18, 2024
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
…ationAlgorithm` (acts-project#3111) Adds a `qop` coefficient term to the initial covariance of the estimated track parameters. Since the resolution of `qop` or `p` usually depends on the momentum itself this should allow us to model the initial curvature uncertainty more effectively and improve the track finding procedure.
Ragansu
pushed a commit
to Ragansu/acts
that referenced
this pull request
Apr 19, 2024
…ationAlgorithm` (acts-project#3111) Adds a `qop` coefficient term to the initial covariance of the estimated track parameters. Since the resolution of `qop` or `p` usually depends on the momentum itself this should allow us to model the initial curvature uncertainty more effectively and improve the track finding procedure.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
…ationAlgorithm` (acts-project#3111) Adds a `qop` coefficient term to the initial covariance of the estimated track parameters. Since the resolution of `qop` or `p` usually depends on the momentum itself this should allow us to model the initial curvature uncertainty more effectively and improve the track finding procedure.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
…ationAlgorithm` (acts-project#3111) Adds a `qop` coefficient term to the initial covariance of the estimated track parameters. Since the resolution of `qop` or `p` usually depends on the momentum itself this should allow us to model the initial curvature uncertainty more effectively and improve the track finding procedure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes Performance
Component - Examples
Affects the Examples module
Infrastructure
Changes to build tools, continous integration, ...
Track Finding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
qop
coefficient term to the initial covariance of the estimated track parameters. Since the resolution ofqop
orp
usually depends on the momentum itself this should allow us to model the initial curvature uncertainty more effectively and improve the track finding procedure.