Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Decouple navigation and stepping #3449

Draft
wants to merge 58 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 56 commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
8a66c9f
refactor!: Decouple navigation and stepping
andiwand Aug 19, 2024
9b02bf9
fix try all
andiwand Aug 20, 2024
2a39cbe
reduce changes
andiwand Aug 20, 2024
5c43d94
refactor and fix
andiwand Aug 20, 2024
8d02fc8
fix
andiwand Aug 20, 2024
3c2406b
fix extrapolator tests
andiwand Aug 21, 2024
7d571e1
fix
andiwand Aug 21, 2024
bac5c03
fix direction bug
andiwand Aug 21, 2024
83ecbb9
quick ignore unit test failure
andiwand Aug 21, 2024
e5fc792
hack test again
andiwand Aug 21, 2024
63a1960
disable tests for ubuntu
andiwand Aug 21, 2024
c92beea
Merge branch 'main' of github.com:acts-project/acts into decouple-nav…
andiwand Nov 16, 2024
7013105
Merge branch 'main' of github.com:acts-project/acts into decouple-nav…
andiwand Nov 23, 2024
3f6ee96
port void navigator; clean navigator interface
andiwand Nov 23, 2024
8108cd2
clean includes
andiwand Nov 23, 2024
7308c8f
port direct navigator
andiwand Nov 23, 2024
0b85ef8
implement direct navigator
andiwand Nov 23, 2024
639bb67
port try all navigators
andiwand Nov 23, 2024
587d600
remove dead code
andiwand Nov 23, 2024
c7e3e86
refine interface
andiwand Nov 23, 2024
27c5a0e
navigation target
andiwand Nov 23, 2024
b333f1c
fix
andiwand Nov 23, 2024
d295f1f
Merge branch 'main' of github.com:acts-project/acts into decouple-nav…
andiwand Nov 23, 2024
a7c705a
fix try all navigators
andiwand Nov 24, 2024
6230cad
port detector navigator
andiwand Nov 24, 2024
a324b88
fix unused variable
andiwand Nov 24, 2024
4419bfd
fix gsf
andiwand Nov 24, 2024
8325a18
simplify propagation code
andiwand Nov 24, 2024
981b6ee
clean
andiwand Nov 24, 2024
9ce8e1e
simplify interface; major navigator refactor
andiwand Nov 24, 2024
35bb79d
renavigation for navigator; cleanup; fix direct navigator
andiwand Nov 24, 2024
41ed6d4
doc
andiwand Nov 25, 2024
2468cf5
fix doc
andiwand Nov 25, 2024
99bf37b
fix docs
andiwand Nov 25, 2024
37ef3d9
revert tests; update navigator unit test
andiwand Nov 25, 2024
b60681f
update detector navigator unit test
andiwand Nov 25, 2024
1896876
re-enable tests
andiwand Nov 25, 2024
004ed2c
Merge branch 'main' of github.com:acts-project/acts into decouple-nav…
andiwand Nov 27, 2024
9465c39
Merge branch 'main' into decouple-navigation-stepping
andiwand Dec 9, 2024
f0e2b25
pr feedback
andiwand Dec 9, 2024
059d4a9
fix candidate iteration for `TryAllOverstepNavigator`
andiwand Dec 9, 2024
eefbe50
fix test after propagator change; rename constrained step slots
andiwand Dec 9, 2024
4b44b5c
handle navigation reset gracefully
andiwand Dec 9, 2024
8e4ee9b
fix sonar cloud issue
andiwand Dec 9, 2024
21cd2d0
Merge branch 'main' of github.com:acts-project/acts into decouple-nav…
andiwand Dec 9, 2024
00ffc14
Merge branch 'main' of github.com:acts-project/acts into decouple-nav…
andiwand Dec 13, 2024
48d5905
pr feedback
andiwand Dec 13, 2024
448ccca
ci and ai feedback
andiwand Dec 13, 2024
5ab184d
fix some unit tests
andiwand Dec 13, 2024
1adb9be
fix navigator
andiwand Dec 13, 2024
f621b53
minor
andiwand Dec 13, 2024
e919b19
clean stepper state creation further
andiwand Dec 13, 2024
0e7747a
fix doc
andiwand Dec 13, 2024
8a4efd8
fix more doc
andiwand Dec 13, 2024
56d3f93
fix tests
andiwand Dec 13, 2024
2f506b2
fix tracking volume resolution
andiwand Dec 13, 2024
005eba6
Merge branch 'main' of github.com:acts-project/acts into decouple-nav…
andiwand Dec 16, 2024
833f510
avoid some gsf diff
andiwand Dec 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
337 changes: 132 additions & 205 deletions Core/include/Acts/Navigation/DetectorNavigator.hpp

Large diffs are not rendered by default.

11 changes: 0 additions & 11 deletions Core/include/Acts/Navigation/NavigationState.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@

#include "Acts/Definitions/Algebra.hpp"
#include "Acts/Definitions/Units.hpp"
#include "Acts/Geometry/GeometryContext.hpp"
#include "Acts/Surfaces/BoundaryTolerance.hpp"
#include "Acts/Utilities/Delegate.hpp"
#include "Acts/Utilities/Intersection.hpp"

#include <any>
Expand Down Expand Up @@ -59,15 +57,6 @@ struct NavigationState {
/// The current direction
Vector3 direction = Vector3(0., 0., 0.);

/// The current absolute momentum
double absMomentum = 0.;

/// The current absolute charge
double absCharge = 0.;

/// The current magnetic field
Vector3 magneticField = Vector3(0., 0., 0.);

/// The current detector in processing
const Detector* currentDetector = nullptr;

Expand Down
Loading
Loading