-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Memory dense MeasurementContainer
for Examples
#3528
feat: Memory dense MeasurementContainer
for Examples
#3528
Conversation
This reverts commit 5725e8b.
64471b8
to
2ffb4dd
Compare
MeasurementContainer
for ExamplesMeasurementContainer
for Examples
single ttbar event with PU 200 and Fatras and ODD main
changed
22,6 MB -> 7,7 MB ~ factor 3 compared to the track edm
given
it looks like we have to add them up. also this will not contain any track information but that only scales with 1321 which is not significant here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, none of them critical. I think just a little bit of documentation would be good.
Examples/Framework/include/ActsExamples/EventData/Measurement.hpp
Outdated
Show resolved
Hide resolved
Examples/Framework/include/ActsExamples/EventData/Measurement.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Quality Gate passedIssues Measures |
MeasurementContainer
which packs the numbers denselyThe motivation for this is to use the memory efficiently and potentially improve track finding performance in the Examples framework.
blocked by