refactor: Remove GX2F start volume checks #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJPfleger
reviewed
Aug 30, 2024
AJPfleger
previously approved these changes
Aug 30, 2024
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
|
AJPfleger
approved these changes
Aug 31, 2024
acts-project-service
added
the
Breaks Athena build
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 31, 2024
…ry::lowestTrackingVolume` (#3481) Currently `TrackingGeometry::lowestTrackingVolume` will always return at least the world volume even though the given position is not inside the world volume. In this PR I change the behavior to return `nullptr` in case we are outside the tracking geometry. Same is done for `TrackingVolume::lowestTrackingVolume`. The rest are necessary fixes and downstream changes to make this work. blocked by - #3581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not play nice with #3481 and I think the initial assumption changed. As long as the start surface is not part of the tracking geometry the navigator will decide on the volume by looking up through the tracking geometry. Change of volume would only be a problem if we start on a surface from the tracking geometry outside its bounds.