Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rework tracklet handling in Examples track finding #3587

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Sep 2, 2024

Reworks the tracklet handling in the Examples track finding algorithm a bit. The extrapolation will now be done anyways if the CKF did not do it which can happen in case the branch stopper stops and keeps a tracklet. Instead of resetting parts of the track quantities here and there we now copy them explicitly from the previous known and desired state.

branched out from #3534

@andiwand andiwand added this to the next milestone Sep 2, 2024
@github-actions github-actions bot added Component - Examples Affects the Examples module Track Finding labels Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

📊: Physics performance monitoring for c256da9

Full contents

physmon summary

@andiwand andiwand requested a review from timadye September 2, 2024 18:27
@andiwand andiwand marked this pull request as ready for review September 2, 2024 18:27
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Sep 2, 2024
Copy link
Contributor

@timadye timadye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good - as far as I can understand.
This PR gives me a 2% speedup wrt main for ttbar_pu200 full_chain_itk.py 😁
... oh, and no appreciable change in the efficiency or fakes.

@andiwand andiwand added automerge and removed Fails Athena tests This PR causes a failure in the Athena tests labels Sep 3, 2024
Copy link

sonarqubecloud bot commented Sep 4, 2024

@kodiakhq kodiakhq bot merged commit b2cd8fb into acts-project:main Sep 4, 2024
45 checks passed
@github-actions github-actions bot removed the automerge label Sep 4, 2024
@andiwand andiwand deleted the ex-refactor-tracklet-handling branch September 4, 2024 20:28
kodiakhq bot pushed a commit that referenced this pull request Sep 6, 2024
Adding an overload to the Core CKF which allows the user to supply a root branch. This is useful if the finding has multiple stages, i.e. forward and backward, and the tip state quantities like `nMeasurements` and `nHoles` should persist so the branch stopper can observe them.

blocked by
- #3586
- #3587
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants