-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rework tracklet handling in Examples track finding #3587
refactor: Rework tracklet handling in Examples track finding #3587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good - as far as I can understand.
This PR gives me a 2% speedup wrt main
for ttbar_pu200 full_chain_itk.py
😁
... oh, and no appreciable change in the efficiency or fakes.
Quality Gate passedIssues Measures |
Adding an overload to the Core CKF which allows the user to supply a root branch. This is useful if the finding has multiple stages, i.e. forward and backward, and the tip state quantities like `nMeasurements` and `nHoles` should persist so the branch stopper can observe them. blocked by - #3586 - #3587
Reworks the tracklet handling in the Examples track finding algorithm a bit. The extrapolation will now be done anyways if the CKF did not do it which can happen in case the branch stopper stops and keeps a tracklet. Instead of resetting parts of the track quantities here and there we now copy them explicitly from the previous known and desired state.
branched out from #3534