Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improved Python bindings for algebra types #3611

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Sep 13, 2024

This aligns the algebra API in python more closely with the C++ one. While I don't want to add too much binding code, I think it's preferable to stick to the Eigen API rather than make up extra custom API just for the sake of exposing it to Python.

To this end, I'm exposing more constructors for the Vector classes, and adding Translation3 and AngleAxis3 as Python types, and allow operators for multiplication and so on between transforms.

At the same time, I'm using this PR to also align some enums we expose to the C++ ones.

@paulgessinger paulgessinger added this to the next milestone Sep 13, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Sep 13, 2024
Copy link

github-actions bot commented Sep 13, 2024

📊: Physics performance monitoring for 4cc7abe

Full contents

physmon summary

@paulgessinger paulgessinger marked this pull request as ready for review September 17, 2024 08:05
Copy link

@kodiakhq kodiakhq bot merged commit c334ce4 into acts-project:main Sep 19, 2024
42 checks passed
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants