-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: TrackingGeometry interface cleanup #3612
Merged
paulgessinger
merged 9 commits into
acts-project:main
from
paulgessinger:refactor/tracking-geometry-interface
Sep 18, 2024
Merged
refactor: TrackingGeometry interface cleanup #3612
paulgessinger
merged 9 commits into
acts-project:main
from
paulgessinger:refactor/tracking-geometry-interface
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adjusts the python bindings
Also removes the typedefs for volume shared pointers.
github-actions
bot
added
Component - Core
Affects the Core module
Infrastructure
Changes to build tools, continous integration, ...
Component - Examples
Affects the Examples module
labels
Sep 16, 2024
asalzburger
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
benjaminhuth
approved these changes
Sep 18, 2024
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Component - Plugins
Affects one or more Plugins
Infrastructure
Changes to build tools, continous integration, ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TrackingGeometry
(essentially unused)TrackingGeometry
holds the world volume as a mutable