Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: TrackingGeometry interface cleanup #3612

Conversation

paulgessinger
Copy link
Member

  • Remove the beamline surface from TrackingGeometry (essentially unused)
  • Remove unneeded shared ptr access to the highest volume
  • TrackingGeometry holds the world volume as a mutable

@paulgessinger paulgessinger added this to the v37.0.0 milestone Sep 16, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module labels Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

📊: Physics performance monitoring for 8f7b5bb

Full contents

physmon summary

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Sep 17, 2024
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.3% Coverage on New Code (required ≥ 25%)
16.67% Line Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@paulgessinger paulgessinger merged commit 1451304 into acts-project:main Sep 18, 2024
42 of 44 checks passed
@paulgessinger paulgessinger deleted the refactor/tracking-geometry-interface branch September 18, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants