Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make ViewConfig usable with designated initializers #3613

Merged

Conversation

paulgessinger
Copy link
Member

Allows removing the custom constructors that were used for convenience.

Allows removing the custom constructors that were used for convenience.
@paulgessinger paulgessinger added this to the v37.0.0 milestone Sep 16, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Sep 16, 2024
AJPfleger
AJPfleger previously approved these changes Sep 16, 2024
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@AJPfleger
Copy link
Contributor

We also use the ViewConfig in some other places like the Gx2fTests.cpp. Maybe we could directly replace it there as well.

@paulgessinger
Copy link
Member Author

@AJPfleger Absolutely, just forgot to include this here.

Copy link

github-actions bot commented Sep 16, 2024

📊: Physics performance monitoring for 9cd5062

Full contents

physmon summary

Copy link

@kodiakhq kodiakhq bot merged commit 2a85c69 into acts-project:main Sep 16, 2024
44 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Fails Athena tests This PR causes a failure in the Athena tests Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants