Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use structured bindings #3632

Merged
merged 15 commits into from
Oct 21, 2024
Merged

refactor: use structured bindings #3632

merged 15 commits into from
Oct 21, 2024

Conversation

AJPfleger
Copy link
Contributor

No description provided.

@AJPfleger AJPfleger added this to the next milestone Sep 19, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Vertexing Track Finding labels Sep 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

📊: Physics performance monitoring for 15cc7cc

Full contents

physmon summary

@andiwand andiwand changed the title refcator: use structured bindings refactor: use structured bindings Sep 20, 2024
stephenswat
stephenswat suggested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking.

Core/src/Detector/detail/CuboidalDetectorHelper.cpp Show resolved Hide resolved
Core/src/Material/BinnedSurfaceMaterialAccumulater.cpp Show resolved Hide resolved
Core/src/TrackFinding/AmbiguityTrackClustering.cpp Show resolved Hide resolved
Core/src/TrackFinding/GbtsConnector.cpp Show resolved Hide resolved
Core/src/TrackFinding/GbtsConnector.cpp Show resolved Hide resolved
Core/src/TrackFinding/GbtsConnector.cpp Outdated Show resolved Hide resolved
Examples/Framework/src/Validation/TrackClassification.cpp Show resolved Hide resolved
Examples/Framework/src/Validation/TrackClassification.cpp Show resolved Hide resolved
Examples/Framework/src/Validation/TrackClassification.cpp Show resolved Hide resolved
@AJPfleger AJPfleger requested a review from stephenswat October 18, 2024 09:09
@AJPfleger AJPfleger marked this pull request as ready for review October 18, 2024 23:10
stephenswat
stephenswat approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve. 👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
28.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit 7b71164 into acts-project:main Oct 21, 2024
42 checks passed
@AJPfleger AJPfleger deleted the structured-bindings branch October 21, 2024 11:26
@acts-project-service
Copy link
Collaborator

✅ Athena integration test results [7b71164]

✅ All tests successful

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 run_workflow_tests_run4_mc
🟡 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 test_ActsDumpGeometryIdentifiers
🟢 test_ActsCheckObjectCountsCachedWorkflow
🟢 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_unit_tests

@paulgessinger paulgessinger modified the milestones: next, v37.2.0 Oct 24, 2024
Rosie-Hasan pushed a commit to Rosie-Hasan/acts that referenced this pull request Nov 13, 2024
@AJPfleger @Rosie-Hasan
refactor: use structured bindings (acts-project#3632)
ae77240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger left review comments

@stephenswat stephenswat stephenswat approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Track Finding Vertexing
Projects
None yet
Milestone
v37.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AJPfleger @acts-project-service @paulgessinger @stephenswat