Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util): Add GraphViz helper types #3635

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Sep 20, 2024

Adds some helper types to work with GraphViz output.

This allows writing code like

  Node node1{.id = "node1",
             .label = "Node 1",
             .shape = Shape::Ellipse,
             .style = {Style::Filled}};

  ss << node1;

  Node node2{.id = "node2",
             .label = "Node 2",
             .shape = Shape::Rectangle,
             .style = {Style::Dashed}};

  Edge edge = {.from = node1, .to = node2, .style = Style::Dashed};

ss << edge;

and get valid GraphViz output.

@paulgessinger paulgessinger added this to the v37.0.0 milestone Sep 20, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Sep 20, 2024
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool, that will allow to use it at more places consistently.

Copy link

📊: Physics performance monitoring for f110c4e

Full contents

physmon summary

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.6% Coverage on New Code (required ≥ 25%)
17.84% Line Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@paulgessinger paulgessinger merged commit 4aa7d19 into acts-project:main Sep 20, 2024
43 of 45 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants