perf: Use sympy generated transport jacobians for sympy covariance transport #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
andiwand
changed the title
paulgessinger
previously approved these changes
Sep 26, 2024
|
Hashes change, physmon seems happy. Can you update the references @andiwand? |
|
@paulgessinger I would like to merge #3648 first to avoid conflicts since I updated the references there already. Is this fine for you? |
github-actions
bot
added
Component - Examples
paulgessinger
approved these changes
Sep 26, 2024
|
acts-project-service
added
the
Breaks Athena build
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Sep 26, 2024
…ansport (acts-project#3650) Apparently this got lost at some point. Until now we used the Eigen implementation of the jacobian transport even though a sympy version was already preset. I fixed the include and explicitly mentioned the `sympy` namespace. This popped out of a recent profile I did on the track finding.
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Sep 26, 2024
…ansport (acts-project#3650) Apparently this got lost at some point. Until now we used the Eigen implementation of the jacobian transport even though a sympy version was already preset. I fixed the include and explicitly mentioned the `sympy` namespace. This popped out of a recent profile I did on the track finding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently this got lost at some point. Until now we used the Eigen implementation of the jacobian transport even though a sympy version was already preset. I fixed the include and explicitly mentioned the
sympynamespace.This popped out of a recent profile I did on the track finding.