feat: Add estimateTrackParamCovariance to Core
#3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
paulgessinger
approved these changes
Oct 17, 2024
|
Rosie-Hasan
pushed a commit
to Rosie-Hasan/acts
that referenced
this pull request
Nov 13, 2024
Add a `estimateTrackParamCovariance` function to Core to estimate the initial covariance of track parameters after seeding. blocked by - acts-project#3665 --- This pull request introduces a new function for estimating track parameter covariance and refactors existing code to utilize this new function. The changes improve code modularity and maintainability by centralizing the covariance estimation logic. ### New Functionality: * [`Core/include/Acts/Seeding/EstimateTrackParamsFromSeed.hpp`](diffhunk://#diff-1d63df6364bcd57d6eae717e4c8dea355f07a36f5fca41b0e9fefdbf3224c0a0R292-R335): Added `EstimateTrackParamCovarianceConfig` struct and `estimateTrackParamCovariance` function to estimate track parameter covariance. ### Refactoring: * [`Examples/Algorithms/TrackFinding/src/TrackParamsEstimationAlgorithm.cpp`](diffhunk://#diff-3fa61f411627effaf29755fa1d539c90bbd2c5155f04c4fa7a0d7f36d99340f3L38-L79): Removed the `makeInitialCovariance` function and replaced its usage with the new `estimateTrackParamCovariance` function. This change simplifies the code by removing redundant logic. [[1]](diffhunk://#diff-3fa61f411627effaf29755fa1d539c90bbd2c5155f04c4fa7a0d7f36d99340f3L38-L79) [[2]](diffhunk://#diff-3fa61f411627effaf29755fa1d539c90bbd2c5155f04c4fa7a0d7f36d99340f3L174-R144) * [`Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/ParticleSmearing.cpp`](diffhunk://#diff-d4047681edb055a3b4ca13bb837f6fef194fd0c8b3205f337db73e97f4b6de82L131-R141): Updated the covariance calculation to use the new `estimateTrackParamCovariance` function, ensuring consistency across the codebase. ### Miscellaneous: * [`Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/ParticleSmearing.cpp`](diffhunk://#diff-d4047681edb055a3b4ca13bb837f6fef194fd0c8b3205f337db73e97f4b6de82R14): Included the `EstimateTrackParamsFromSeed.hpp` header to access the new covariance estimation function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
estimateTrackParamCovariancefunction to Core to estimate the initial covariance of track parameters after seeding.blocked by
q/pcovariance term inTrackParamsEstimationAlgorithmin Examples #3665This pull request introduces a new function for estimating track parameter covariance and refactors existing code to utilize this new function. The changes improve code modularity and maintainability by centralizing the covariance estimation logic.
New Functionality:
Core/include/Acts/Seeding/EstimateTrackParamsFromSeed.hpp: AddedEstimateTrackParamCovarianceConfigstruct andestimateTrackParamCovariancefunction to estimate track parameter covariance.Refactoring:
Examples/Algorithms/TrackFinding/src/TrackParamsEstimationAlgorithm.cpp: Removed themakeInitialCovariancefunction and replaced its usage with the newestimateTrackParamCovariancefunction. This change simplifies the code by removing redundant logic. [1] [2]Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/ParticleSmearing.cpp: Updated the covariance calculation to use the newestimateTrackParamCovariancefunction, ensuring consistency across the codebase.Miscellaneous:
Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/ParticleSmearing.cpp: Included theEstimateTrackParamsFromSeed.hppheader to access the new covariance estimation function.